[CARBONDATA-2550][CARBONDATA-2576][MV] Fix limit and average function issue in MV query #2480
Conversation
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5763/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/6999/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5751/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7090/ |
ravipesala
force-pushed
the
mv-2550
branch
2 times, most recently
from
3b7885e
to
5d2634e
Compare
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7190/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/5965/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5856/ |
| case agg: AggregateExpression => agg | ||
| case agg: AggregateExpression => | ||
| isFullReload = agg.aggregateFunction match { | ||
| case avg: Average => true |
There was a problem hiding this comment.
Can you add comment to explain why it is true
| @@ -385,7 +390,7 @@ object MVHelper { | |||
| val relation = | |||
| g.dataMapTableRelation.get.asInstanceOf[MVPlanWrapper].plan.asInstanceOf[Select] | |||
| val aliasMap = getAttributeMap(relation.outputList, g.outputList) | |||
| val updatedFlagSpec: Seq[Seq[ArrayBuffer[SortOrder]]] = updateSortOrder( | |||
| val updatedFlagSpec: Seq[Seq[Any]] = updateSortOrder( | |||
There was a problem hiding this comment.
Is this for limit to work? can you add comment
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7288/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6055/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7298/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6065/ |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5918/ |
| @@ -429,7 +436,7 @@ object MVHelper { | |||
| /** | |||
| * Updates the flagspec of given select plan with attributes of relation select plan | |||
| */ | |||
| private def updateSortOrder(keepAlias: Boolean, | |||
| private def updateFlagSpec(keepAlias: Boolean, | |||
| select: Select, | |||
| relation: Select, | |||
| aliasMap: Map[AttributeKey, NamedExpression]) = { | |||
There was a problem hiding this comment.
please add return type to this func
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7417/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6182/ |
|
The conflict is due to test case adding in #2476 |
… issue in MV query Problem: Limit is not working on mv queries and the average is also not working. Solution: Correct the limit queries and average queries through making as full refresh query. This closes #2480
This PR depends on #2453
Problem: Limit is not working on mv queries and the average is also not working.
Solution: Correct the limit queries and average queries through making as full refresh query.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.