[CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap if, target data type is SHORT_INT #2546
Conversation
…et datatype is SHORT_INT
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7438/ |
|
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6195/ |
|
@ravipesala : please review |
|
LGTM |
|
retest SDV please |
|
retest sdv please |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6000/ |
| .addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT, | ||
| "false") | ||
| } | ||
|
|
There was a problem hiding this comment.
- only beforeAll and afterAll implementation is there....where is the test case?
- Avoid creating a new class, try to add the test case in one of existing Encoding test case related classes
There was a problem hiding this comment.
- This new class extends, TestAdaptiveComplexType . So all the test case present in that will run with this carbon property set. we need both the scenarios to test with and without property.
- Actually in this case creating a new class by extending one class has avoided the duplication of the test case. It is very efficient test case !
|
retest sdv please |
|
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6009/ |
|
@kumarvishal09 : PR is ready. please Merge |
|
retest this please |
|
retest sdv please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7587/ |
|
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6342/ |
|
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/6048/ |
|
LGTM |
…et datatype is SHORT_INT problem: [CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap if, target data type is SHORT_INT solution: If ENABLE_OFFHEAP_SORT = false, in carbon property. UnsafeFixLengthColumnPage.java will use different compress logic. Not the raw compression. In that case, for SHORT_INT data type , conversion need to handle. This closes #2546
…et datatype is SHORT_INT problem: [CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap if, target data type is SHORT_INT solution: If ENABLE_OFFHEAP_SORT = false, in carbon property. UnsafeFixLengthColumnPage.java will use different compress logic. Not the raw compression. In that case, for SHORT_INT data type , conversion need to handle. This closes apache#2546
problem:
[CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap if, target data type is SHORT_INT
solution: If ENABLE_OFFHEAP_SORT = false, in carbon property. UnsafeFixLengthColumnPage.java will use different compress logic. Not the raw compression. In that case, for SHORT_INT data type , conversion need to handle.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed? NA
Any backward compatibility impacted? NA
Document update required? NA
Testing done
updated UT. Which will run all adaptive test cases with ENABLE_OFFHEAP_SORT = false.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. NA