Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CARBONDATA-2775] Adaptive encoding fails for Unsafe OnHeap if, target data type is SHORT_INT #2546

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,8 @@ private int getEndLoop() {
return totalLength / ByteUtil.SIZEOF_BYTE;
} else if (dataType == DataTypes.SHORT) {
return totalLength / ByteUtil.SIZEOF_SHORT;
} else if (dataType == DataTypes.SHORT_INT) {
return totalLength / ByteUtil.SIZEOF_SHORT_INT;
} else if (dataType == DataTypes.INT) {
return totalLength / ByteUtil.SIZEOF_INT;
} else if (dataType == DataTypes.LONG) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.carbondata.integration.spark.testsuite.complexType

import java.io.File

import org.apache.spark.sql.test.util.QueryTest
import org.scalatest.BeforeAndAfterAll

import org.apache.carbondata.core.constants.CarbonCommonConstants
import org.apache.carbondata.core.util.CarbonProperties

/**
* Test class of Adaptive Encoding UnSafe Column Page with Complex Data type
*
*/

class TestAdaptiveEncodingUnsafeHeapColumnPageForComplexDataType
extends QueryTest with BeforeAndAfterAll with TestAdaptiveComplexType {

override def beforeAll(): Unit = {

new File(CarbonProperties.getInstance().getSystemFolderLocation).delete()
sql("DROP TABLE IF EXISTS adaptive")
CarbonProperties.getInstance()
.addProperty(CarbonCommonConstants.ENABLE_UNSAFE_COLUMN_PAGE,
"true")

CarbonProperties.getInstance()
.addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT,
"false")
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. only beforeAll and afterAll implementation is there....where is the test case?
  2. Avoid creating a new class, try to add the test case in one of existing Encoding test case related classes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manishgupta88 :

  1. This new class extends, TestAdaptiveComplexType . So all the test case present in that will run with this carbon property set. we need both the scenarios to test with and without property.
  2. Actually in this case creating a new class by extending one class has avoided the duplication of the test case. It is very efficient test case !

override def afterAll(): Unit = {
sql("DROP TABLE IF EXISTS adaptive")
CarbonProperties.getInstance()
.addProperty(CarbonCommonConstants.ENABLE_UNSAFE_COLUMN_PAGE,
"true")

CarbonProperties.getInstance()
.addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT,
"true")
}


}