Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CARBONDATA-2982] CarbonSchemaReader support array<string> #2780

Closed
wants to merge 4 commits into from
Closed

[CARBONDATA-2982] CarbonSchemaReader support array<string> #2780

wants to merge 4 commits into from

Conversation

xubo245
Copy link
Contributor

@xubo245 xubo245 commented Sep 28, 2018 •
edited
Loading

This PR fix the issue and change :
org.apache.carbondata.sdk.file.CarbonSchemaReader#readSchemaInDataFile
org.apache.carbondata.sdk.file.CarbonSchemaReader#readSchemaInIndexFile

This PR remove child schema

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed?
    No
  • Any backward compatibility impacted?
    No
  • Document update required?
    No
  • Testing done
    add test code
  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
    No

@xubo245 xubo245 changed the title Carbondata 2982 support array string in schema [CARBONDATA-2982] CarbonSchemaReader support array<string> Sep 28, 2018
@xubo245 xubo245 force-pushed the CARBONDATA-2982_supportArrayStringInSchema branch from 7110a8b to 8da2797 Compare September 28, 2018 04:05
@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/620/

@CarbonDataQA
Copy link

Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8881/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/812/

@xubo245
Copy link
Contributor Author

xubo245 commented Sep 28, 2018

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/623/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8884/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/815/

KanakaKumar
KanakaKumar reviewed Sep 28, 2018
View reviewed changes
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonReaderTest.java Outdated
System.out.println();
i++;
}
System.out.println("\nFinished");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove Sys out content

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, done

@ajantha-bhat
Copy link
Member

LGTM except for minor test case comment by @KanakaKumar .

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/647/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/842/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8910/

@xubo245
Copy link
Contributor Author

xubo245 commented Sep 29, 2018

@KanakaKumar @ajantha-bhat removed

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/651/

@CarbonDataQA
Copy link

Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8914/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/846/

@xubo245
Copy link
Contributor Author

xubo245 commented Sep 29, 2018

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/655/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8918/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/850/

@KanakaKumar
Copy link
Contributor

LGTM

@manishgupta88
Copy link
Contributor

retest this please

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/679/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/874/

@CarbonDataQA
Copy link

Build Failed with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/8942/

@asfgit asfgit closed this in d8a51c9 Oct 3, 2018
xuchuanyin pushed a commit to xuchuanyin/carbondata that referenced this pull request Oct 19, 2018
@xubo245 @xuchuanyin
[CARBONDATA-2982] CarbonSchemaReader support array<string>
1e50004 
This PR fix the issue and change :
org.apache.carbondata.sdk.file.CarbonSchemaReader#readSchemaInDataFile
org.apache.carbondata.sdk.file.CarbonSchemaReader#readSchemaInIndexFile

This PR remove child schema

This closes apache#2780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KanakaKumar KanakaKumar KanakaKumar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xubo245 @CarbonDataQA @ajantha-bhat @KanakaKumar @manishgupta88