[HOTFIX]fixed loading issue for legacy store #3170
Conversation
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2831/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11091/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3062/ |
| // sort step's output is based on sort column order i.e sort columns data will be present | ||
| // ahead of non sort columns, so table spec also need to add dimension spec in same manner | ||
| for (int i = 0; i < dimensions.size(); i++) { | ||
| CarbonDimension dimension = dimensions.get(i); | ||
| if (dimension.isComplex()) { | ||
| spec = new DimensionSpec(ColumnType.COMPLEX, dimension, actualPosition++); | ||
| spec = new DimensionSpec(ColumnType.COMPLEX, dimension, (short) 0); |
There was a problem hiding this comment.
Why is it '0' ? if this table has multiply complex type
There was a problem hiding this comment.
Here also please keep them in noDimActualPosition
| @@ -84,19 +84,20 @@ private void addDimensions(List<CarbonDimension> dimensions) { | |||
| List<DimensionSpec> dictDimensionSpec = new ArrayList<>(); | |||
| int dimIndex = 0; | |||
| DimensionSpec spec; | |||
| short actualPosition = 0; | |||
| short dictActualPosition = 0; | |||
| short noDimActualPosition = 0; | |||
There was a problem hiding this comment.
Please rename as noDictActualPosition
There was a problem hiding this comment.
done, please review and merge
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3063/ |
|
retest this please |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3064/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2832/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2833/ |
|
retest this please |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3065/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2834/ |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2835/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11095/ |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3066/ |
|
retest this please |
|
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3067/ |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2836/ |
|
Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11096/ |
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2837/ |
|
Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11097/ |
|
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3068/ |
fixed loading issue for legacy store This closes #3170
fixed loading issue for legacy store This closes apache#3170
fixed loading issue for legacy store
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.