Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] optimize the presto module name #3267

Closed
wants to merge 1 commit into from
Closed

[HOTFIX] optimize the presto module name #3267

wants to merge 1 commit into from

Conversation

lamberken
Copy link
Member

@lamberken lamberken commented Jun 9, 2019

This pr aims to optimize the presto module name.

Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:

  • Any interfaces changed? NO

  • Any backward compatibility impacted? NO

  • Document update required? NO

  • Testing done YES
    Please provide details on
    - Whether new unit test cases have been added or why no new tests are required?
    - How it is tested? Please attach test report.
    - Is it a performance related change? Please attach the performance test report.
    - Any additional information to help reviewers in testing this change.

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. OK

@CarbonDataQA
Copy link

Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/3471/

@CarbonDataQA
Copy link

Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/3674/

@CarbonDataQA
Copy link

Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/11738/

@ajantha-bhat
Copy link
Member

@lamber-ken : LGTM.

But if any other PR is open from you. suggest to add this change in that PR.
For one letter change (which has no function impact) may be no need separate PR.

@lamberken
Copy link
Member Author

@lamber-ken : LGTM.

But if any other PR is open from you. suggest to add this change in that PR.
For one letter change (which has no function impact) may be no need separate PR.

Thanks for your comment @ajantha-bhat, ok, I see. that's why I use [HOTFIX] as the title.

@brijoobopanna
Copy link
Contributor

@lamber-ken :HOTFIX can be used for CI failure and other urgent blocking issues

@lamberken
Copy link
Member Author

@brijoobopanna,thanks,btw,what's the right way to fix the minor bug. May be it is not suitable to add it to another PR. Because it may be not suitable to another PR's purpose

@brijoobopanna
Copy link
Contributor

Thanks, @lamber-ken better to include with your other PR

@CarbonDataQA
Copy link

Build Failed with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/20/

@lamberken lamberken closed this Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants