[CARBONDATA-3523] Store data file size into index file #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/317/ |
|
Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/313/ |
|
Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/313/ |
QiangCai
changed the title
|
retest this please |
|
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/552/ |
|
Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/553/ |
|
Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/556/ |
|
LGTM |
QiangCai
added a commit
to QiangCai/carbondata
that referenced
this pull request
Sep 29, 2019
In BlockIndex, the file_size is always zero. We can set the actual value during data loading and use it during the query to improve the query performance. 1. avoid invoking listFiles for each segment 2. avoid invoking getFileStatus for each data file This closes apache#3356
asfgit
pushed a commit
that referenced
this pull request
Oct 4, 2019
In BlockIndex, the file_size is always zero. We can set the actual value during data loading and use it during the query to improve the query performance. 1. avoid invoking listFiles for each segment 2. avoid invoking getFileStatus for each data file This closes #3356
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store data file size into the index file
[Background]
In BlockIndex, the file_size is always zero. We can set the actual value during data loading and use it during the query to improve the scenario of disaggregated compute and storage.
[Benefi]
For cloud and local table, it will help to improve the driver performance of the first query.
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.