[HOTFIX] Ignore testcase for compatibility problem in spark 2.1 #3457
Conversation
|
Build Success with Spark 2.1.0, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.1/853/ |
| @@ -134,7 +134,9 @@ class TestCreateTableLike extends QueryTest with BeforeAndAfterEach with BeforeA | |||
| assert(exception.getMessage.contains("already exists in database")) | |||
| } | |||
|
|
|||
| test("command with location") { | |||
| // ignore this test case since Spark 2.1 does not support specify location | |||
| // and also current implementation in carbon does not use this parameter. | |||
There was a problem hiding this comment.
If Spark version is 2.2 and above, then also this test will be ignored. Instead you can use 'SparkUtil.isSparkVersionXandAbove("2.2")' in your test case and check for it. You can refer to the test class 'TestCreateTableUsingSparkCarbonFileFormat'.
There was a problem hiding this comment.
actually we ignore the location parameter in carbon now. This parameter will have no effect for spark 2.2+ for current version. Keep it as a reminder.
|
Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/859/ |
|
Build Success with Spark 2.3.2, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/861/ |
|
LGTM |
2 similar comments
|
LGTM |
|
LGTM |
|
retest this please |
|
Build Success with Spark 2.2.1, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.2/1039/ |
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
Any interfaces changed?
Any backward compatibility impacted?
Document update required?
Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.