Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOTFIX] Ignore testcase for compatibility problem in spark 2.1 #3457

Closed
wants to merge 1 commit into from
Closed

[HOTFIX] Ignore testcase for compatibility problem in spark 2.1 #3457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...rc/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateTableLike.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,9 @@ class TestCreateTableLike extends QueryTest with BeforeAndAfterEach with BeforeA
assert(exception.getMessage.contains("already exists in database"))
}

test("command with location") {
// ignore this test case since Spark 2.1 does not support specify location
// and also current implementation in carbon does not use this parameter.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Spark version is 2.2 and above, then also this test will be ignored. Instead you can use 'SparkUtil.isSparkVersionXandAbove("2.2")' in your test case and check for it. You can refer to the test class 'TestCreateTableUsingSparkCarbonFileFormat'.

Copy link
Member Author

@kevinjmh kevinjmh Nov 14, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually we ignore the location parameter in carbon now. This parameter will have no effect for spark 2.2+ for current version. Keep it as a reminder.

ignore("command with location") {
sql(s"create table targetTable like sourceTable location '$warehouse/tbl_with_loc' ")
checkTableProperties(TableIdentifier("sourceTable"), TableIdentifier("targetTable"))
}
Expand Down