Remove doxygen and references to it #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -82,7 +62,6 @@ In some cases, we organize our test files by putting them in directories. If you | |||
|
|
|||
| - When possible, you should use the assert functions from [`tools/assertions.py`](https://github.com/apache/cassandra-dtest/blob/master/tools/assertions.py). | |||
| - When none of these are applicable, use python's built in [unittest assertions](https://docs.python.org/2/library/unittest.html#assert-methods). | |||
| - Naked assert statements should never be used, e.g. `assert True` | |||
There was a problem hiding this comment.
Also took this out, as it's clearly not adhered to in the codebase.
|
+1! And yes, that naked assert line probably should have been caught with the move to pytest. Nice catch. |
|
Merged. But I forgot to standardise the commit message, my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ptnapoleon as requested and discussed https://wilderness.apache.org/channels/?f=cassandra-dev/2018-05-14#1526273434
I left most of the docstrings section, just renaming it to "Documentatin" as I think these comments still have purpose in the code (they just don't need to be doxygen generated to another place).