Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASSANDRA-18824: Backport CASSANDRA-16418 to 3.x #2921

Closed

Commits on Dec 12, 2023

  1. Backport CASSANDRA-16418 to 3.x

    When a node is decommissioned, it triggers data transfer to other nodes.
    During this transfer process, receiving nodes temporarily hold token ranges in a pending state.
    However, the current cleanup process doesn't account for these pending ranges when calculating token ownership,
    leading to inadvertent cleanup of data already stored in SSTables.
    To address this issue, this patch introduces two changes.
    Firstly, it backports CASSANDRA-16418, introducing a preventive check in `StorageService#forceKeyspaceCleanup`.
    This check disallows the initiation of cleanup when a node contains any pending ranges for the requested keyspace.
    Secondly, it reintroduces a similar condition to test for the existence of pending ranges in `CompactionManager#performCleanup`.
    This ensures the safety of this API as well.
    
    patch by Szymon Miezal; reviewed by TBD for CASSANDRA-18824
    szymon-miezal committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    68625da View commit details
    Browse the repository at this point in the history