Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASSANDRA-19104/2 Default to human-readable in nodetool tablestats #3031

Closed
wants to merge 3 commits into from

Conversation

zaaath
Copy link
Contributor

@zaaath zaaath commented Jan 7, 2024

Default to human-readable in nodetool tablestats. See a discussion on the topic in the dev mailing list dev@cassandra.apache.org

Before

nodetool tablestats doesn't use the human-readable formatting by default (with KiB/MiB/GiB units), instead it outputs data size values as is. In order to switch to the human-readable output, --human-readable or --H CLI flag is required.

After

nodetool tablestats uses the human-readable format by default. For backward compatibility --no-human-readable flag can be used to disable it.

How to reproduce

nodetool tablestats

and

nodetool tablestats --no-human-readable

Tests

ant testsome -Dtest.name=org.apache.cassandra.tools.nodetool.TableStatsTest
ant testsome -Dtest.name=org.apache.cassandra.tools.nodetool.stats.TableStatsPrinterTest

patch by @zaaath; reviewed by ??? for CASSANDRA-19104

@zaaath
Copy link
Contributor Author

zaaath commented Jan 28, 2024

Moved to #3069

@zaaath zaaath closed this Jan 28, 2024
@zaaath zaaath deleted the CASSANDRA-19104-p2 branch January 28, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant