CASSANDRA-19335 Default nodetool tablestats to Human-Readable Output #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an-readable CLI flag to disable human-readable output
…manReadableArg to #testNoHumanReadableArg
driftx
reviewed
Jan 29, 2024
| description = "Display bytes in human readable form, i.e. KiB, MiB, GiB, TiB") | ||
| private boolean humanReadable = false; | ||
| @Option(title = "no_human_readable", | ||
| name = {"--no-human-readable"}, |
There was a problem hiding this comment.
Can we spare a short flag here too?
There was a problem hiding this comment.
Sure! How about -r (for Raw) or -nhr (for No Human Readable)? I'll add -r for now.
There was a problem hiding this comment.
-r short flag added (stands for Raw). Is there anything else missing here?
…formatting) flag is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to human-readable in
nodetool tablestats. See a discussion on the topic in the dev mailing list dev@cassandra.apache.orgBefore
nodetool tablestatsdoesn't use the human-readable formatting by default (with KiB/MiB/GiB units), instead it outputs data size values as is. In order to switch to the human-readable output,--human-readableor--HCLI flag is required.After
nodetool tablestatsuses the human-readable format by default. For backward compatibility--no-human-readableflag can be used to disable it.How to reproduce
and
Tests
patch by @zaaath; reviewed by ??? for CASSANDRA-19335