Relax < check to <= for NodeToolGossipInfoTest #819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beobal
approved these changes
Nov 13, 2020
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Nov 27, 2023
…found (apache#819) This PR fixes two issues. Together, the two issues effectively cancel each other out and work correctly on `vsearch`, however, when we merge the switch proposed in apache#801, we do not get the cancellation. The problem is that for range queries the right bound of an AbstractBound can be less than the left bound, and this matters when finding the `floor` for a token, since our definition of floor does not treat numbers as a ring. The current code works because when the PK does not have a floor, ReversedTrieRangeIterator returns Long.MAX_VALUE, and we get the correct range of sstable row ids. The solution: * Update ReversedTrieRangeIterator to return -1, and adopt the behavior we will see in apache#801. * Update `V2VectorIndexSearcher#bitsOrPostingListForKeyRange` so that it correctly handles the right boundary as the minimum token. This change is covered by the `VectorTypeTest#rangeSearchTest`, which fails if we only implement the first bullet of the solution. Additionally, note that we have have the same usage pattern for `isMinimum` on the right bound in the vector `VectorMemtableIndex#search` method. https://github.com/datastax/cassandra/blob/49a51690caca180fc33bd49c7b95cfc8ee0627f3/src/java/org/apache/cassandra/index/sai/disk/vector/VectorMemtableIndex.java#L170-L171
ekaterinadimitrova2
pushed a commit
to ekaterinadimitrova2/cassandra
that referenced
this pull request
Jun 3, 2024
…found (apache#819) This PR fixes two issues. Together, the two issues effectively cancel each other out and work correctly on `vsearch`, however, when we merge the switch proposed in apache#801, we do not get the cancellation. The problem is that for range queries the right bound of an AbstractBound can be less than the left bound, and this matters when finding the `floor` for a token, since our definition of floor does not treat numbers as a ring. The current code works because when the PK does not have a floor, ReversedTrieRangeIterator returns Long.MAX_VALUE, and we get the correct range of sstable row ids. The solution: * Update ReversedTrieRangeIterator to return -1, and adopt the behavior we will see in apache#801. * Update `V2VectorIndexSearcher#bitsOrPostingListForKeyRange` so that it correctly handles the right boundary as the minimum token. This change is covered by the `VectorTypeTest#rangeSearchTest`, which fails if we only implement the first bullet of the solution. Additionally, note that we have have the same usage pattern for `isMinimum` on the right bound in the vector `VectorMemtableIndex#search` method. https://github.com/datastax/cassandra/blob/49a51690caca180fc33bd49c7b95cfc8ee0627f3/src/java/org/apache/cassandra/index/sai/disk/vector/VectorMemtableIndex.java#L170-L171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.