-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1258] Add UserIdentifier into the master application meta #2296
Conversation
@@ -611,6 +612,7 @@ message PbSnapshotMetaInfo { | |||
repeated PbWorkerInfo shutdownWorkers = 13; | |||
repeated PbWorkerInfo manuallyExcludedWorkers = 14; | |||
map<string, PbWorkerEventInfo> workerEventInfos = 15; | |||
map<string, PbApplicationInfo> applications = 16; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use a different field number with deprecated appHeartbeatTime?
map<string, int64> appHeartbeatTime = 6;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @pan3793
55b28fd
to
d5c3ed0
Compare
d5c3ed0
to
b16dbb2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
==========================================
+ Coverage 48.63% 48.81% +0.18%
==========================================
Files 208 209 +1
Lines 12832 12869 +37
Branches 1104 1105 +1
==========================================
+ Hits 6240 6281 +41
+ Misses 6191 6187 -4
Partials 401 401 ☔ View full report in Codecov by Sentry. |
ok. thanks for the information. |
...src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/protocol/message/ControlMessages.scala
Outdated
Show resolved
Hide resolved
Raised #2365, close this one. |
What changes were proposed in this pull request?
Record the userIdentifier in master application meta.
Also including app totalWritten, fileCount info.
Why are the changes needed?
To close CELEBORN-1258
Does this PR introduce any user-facing change?
Yes.
The result format of master RESTful api
/applications
changed.How was this patch tested?
UT.