Skip to content

Commit

Permalink
CLOUDSTACK-10294: PEP-8 fixes and enhancements to security_group.py (#…
Browse files Browse the repository at this point in the history
…2432)

- We should return a boolean and not a String 'true' or 'false'. Although this output is never checked by the calling function(s).
- Do not use == False or == None as that is not according to the Python specs.
- Calling just print 'hello' is deprecated and won't work in newer Python versions. We should use the print() function.
- Remove unused and commented function.
- Use logging.warning() instead of logging.warn()
- Use subprocess.check_output() for execution. This is the Python way of executing commands.

Signed-off-by: Wido den Hollander <wido@widodh.nl>
  • Loading branch information
wido authored and rohityadavcloud committed Feb 15, 2018
1 parent 39415b7 commit 6233a77
Showing 1 changed file with 92 additions and 82 deletions.
Loading

0 comments on commit 6233a77

Please sign in to comment.