Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logrotate to config in packaging #2857

Closed
glennwagner opened this issue Sep 21, 2018 · 1 comment
Closed

Change logrotate to config in packaging #2857

glennwagner opened this issue Sep 21, 2018 · 1 comment
Labels
component:packaging
Milestone
4.11.2.0

Comments

@glennwagner
Copy link

glennwagner commented Sep 21, 2018 •
edited
Loading

ISSUE TYPE
  • Enhancement Request
COMPONENT NAME
RPM, Packaging, install
CLOUDSTACK VERSION
4.11.1.0
CONFIGURATION
OS / ENVIRONMENT

CentOS

SUMMARY

Consider marking logrotate script as config in the RPM packaging

https://github.com/apache/cloudstack/blob/master/packaging/centos7/cloud.spec#L519

STEPS TO REPRODUCE
EXPECTED RESULTS
%config(noreplace) %{_sysconfdir}/logrotate.d/%{name}-agent
ACTUAL RESULTS
%attr(0644,root,root) %{_sysconfdir}/logrotate.d/%{name}-agent
@rohityadavcloud rohityadavcloud added this to the 4.11.2.0 milestone Sep 21, 2018
rohityadavcloud added a commit to shapeblue/cloudstack that referenced this issue Sep 21, 2018
@rohityadavcloud
packaging: Fixes apache#2857 don't overwrite agent logrotate config
d659d56 
This makes the agent logrotate config to `noreplace` so on upgrade
any changes to the file are not lost.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@rohityadavcloud rohityadavcloud mentioned this issue Sep 21, 2018
Merged
12 tasks
@rohityadavcloud
Copy link
Member

@glennwagner I've fixed it here: #2860 /cc @PaulAngus @mlsorensen

rohityadavcloud added a commit that referenced this issue Sep 25, 2018
@rohityadavcloud
packaging: Fixes #2857 don't overwrite agent logrotate config (#2860)
c2f4b36 
This makes the agent logrotate config to `noreplace` so on upgrade
any changes to the file are not lost.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:packaging
Projects
None yet
Milestone
4.11.2.0
Development

No branches or pull requests
2 participants
@rohityadavcloud @glennwagner