Fix Nio/CPU issue and CI failures #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reverts ea2286 that introduced a wakeup on each connection loop run. - In SSL handshake code removes delegated tasks to be run in separate threads. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
| if (s_logger.isTraceEnabled()) { | ||
| s_logger.trace("SSL: Running delegated task!"); | ||
| } | ||
| task.run(); |
There was a problem hiding this comment.
@jburwell thanks for pointing out, I've made the runnable task run in the current thread only. The delegated tasks in case of SSL handshake could be resolving domain names to address.
|
@rhtyd This patch seems to have fixed the cpu issue. I've got this running on a hardware lab right now. Thought you'd like to know before I hit the sack for the night! |
|
Thanks for the fix @rhtyd and for testing this @kiwiflyer. 👍 |
|
@kiwiflyer Thanks you for testing this so quickly and sharing. |
- Fixes oobm integration test to skip if known ipmitool bug is hit - Fixes ProcessTest unit test case to use sleep - Removes redundant unit test that covers code in ProcessTest Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
changed the title
rohityadavcloud
changed the title
This was referenced May 13, 2016
|
LGTM based on code review. |
|
code LGTM. trusting @kiwiflyer I will probably test later but am a bit stuck today. |
Changes the cleanup sequence as the cleanup code causes exceptions in several Travis runs such as: https://travis-ci.org/apache/cloudstack/jobs/129925224 Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
|
I've also fixed a integration/component test that has failed on Travis several time for various PRs due to cleanup order (tearDown issue): |
|
Most of these things are fixes to Jenkins and travis issues, so those jobs being green is good validation of the fixes. The main functionality change has been validated by @kiwiflyer, so I will get this merged right away. Thanks for being on top of this @rhtyd, I really appreciate it. 👍 |
asfgit
pushed a commit
that referenced
this pull request
May 13, 2016
Fix Nio/CPU issue and CI failures- Reverts ea2286 that introduced a wakeup on each connection loop run. - In SSL handshake code removes delegated tasks to be run in separate threads. /cc @kiwiflyer @swill @jburwell and others for review @kiwiflyer please help me test this fix and share if it makes the NioConnection robust now, without having the selector consume a lot of CPU. Thanks. * pr/1543: test: fix cleanup sequence for test_acl_listvolume test CLOUDSTACK-9299: Fix test failures on CI CLOUDSTACK-9348: Make NioConnectio loop less aggressive Signed-off-by: Will Stevens <williamstevens@gmail.com>
|
Thanks @swill |
|
Thanks for the effort stabilizing Jenkins and Travis the last few days. This has been super helpful as we get close to the freeze. Very much appreciated. Most of the runs are coming back clean now. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @kiwiflyer @swill @jburwell and others for review
@kiwiflyer please help me test this fix and share if it makes the NioConnection robust now, without having the selector consume a lot of CPU. Thanks.