Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Alert codes #1591

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Updating Alert codes #1591

merged 1 commit into from
Nov 20, 2016

Conversation

dcarbone
Copy link
Contributor

@wido
Copy link
Contributor

wido commented Jul 6, 2016

Can maybe @rhtyd comment on this one?

@rohityadavcloud
Copy link
Member

We'll need to check this against the consumers of the response, based on present alert codes we may need to update it. We'll also need to see when the alert code diverged, why some of the alert codes changed (for example HOST etc.)

@jburwell
Copy link
Contributor

I would like to get this PR merged as part of the 4.8.2.0 release, but we don't have much time to get it completed.

@dcarbone could you please create a JIRA ticket explaining the bug/enhancement motivation of this PR? Also, could you please investigate the cause of the Travis build failure?

@rhtyd were you able to complete your analysis?

@dcarbone
Copy link
Contributor Author

@jburwell: JIRA ticket created: https://issues.apache.org/jira/browse/CLOUDSTACK-9468

@jburwell
Copy link
Contributor

jburwell commented Aug 23, 2016 •
edited
Loading

@dcarbone thanks for creating a JIRA ticket. Could you please prepend the headline of your commit message with the ticket ID (i.e. CLOUDSTACK-9468: )? Additionally, the Travis build is failing. Could you please investigate the cause and fix it?

/cc @rhtyd

@rohityadavcloud
Copy link
Member

@dcarbone can you squash your commits and rebase against latest, thanks. Please also amend git commit message to include the JIRA ID.
@jburwell I did not start my analysis, I'll do that once we've sorted out above.

@jburwell
Copy link
Contributor

@rhtyd @dcarbone given that we are trying to get a 4.8 RC cut ASAP (we are week late already), I think it is best to push this PR to 4.9.2.0. Would you mind re-pointing it to the 4.9 branch?

@dcarbone dcarbone changed the base branch from 4.8 to 4.9 September 13, 2016 19:04
@dcarbone
Copy link
Contributor Author

squashed, pointing at 4.9, and commit amended.

@jburwell
Copy link
Contributor

@rhtyd have you had a chance to analyze? I would like to include this change in 4.9.1.0 and 4.10.0.0 for which we are planning to cut RCs on 25 Sept 2016.

@rohityadavcloud
Copy link
Member

LGTM @jburwell I checked the changes against the values defined in AlertService and they check out perfectly.

@rohityadavcloud
Copy link
Member

@jburwell we can merge this, since it's a doc change no tests are needed.

@rohityadavcloud
Copy link
Member

LGTM, this is only a comment change. Changes have been verified, so I'll proceed with merging this.

@asfgit asfgit merged commit b7e520e into apache:4.9 Nov 20, 2016
asfgit pushed a commit that referenced this pull request Nov 20, 2016
@rohityadavcloud
Merge pull request #1591 from myENA/alert-response-doc-update
8c62464 
Updating Alert codesUpdating codes per values present here: https://github.com/apache/cloudstack/blob/4.8/api/src/org/apache/cloudstack/alert/AlertService.java#L39

* pr/1591:
  Updating Alert codes (CLOUDSTACK-9468)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dcarbone @wido @rohityadavcloud @jburwell @asfgit