Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDSTACK-9566 instance-id metadata for baremetal VM returns ID #1738

Merged
merged 1 commit into from
Nov 25, 2016

Conversation

SudharmaJain
Copy link
Contributor

There is difference in instance-id metadata across baremetal and other hypervisors.

On Baremetal
[root@ip-172-17-0-144 ~]# curl http://8.37.203.221/latest/meta-data/instance-id
6021

on Xen
[root@ip-172-17-2-103 ~]# curl http://172.17.0.252/latest/meta-data/instance-id
cbeb517a-e833-4a0c-b1e8-9ed70200fbbf

In both cases it should be vm's uuid.

Copy link
Contributor

@jburwell jburwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SudharmaJain please either update an existing Marvin test case or add one to verify this fix.

@rohityadavcloud
Copy link
Member

@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-182

@rohityadavcloud
Copy link
Member

The changes are in baremetal subsystem, which cannot be tested by current test environments.
The changes LGTM, @karuturi @koushik-das can you review/lgtm on this and confirm any test results from your env?

@koushik-das
Copy link
Contributor

Code changes LGTM.

@serg38
Copy link

serg38 commented Nov 25, 2016

LGTM as well

@rohityadavcloud
Copy link
Member

Thanks all, I'll proceed with the merging as build, travis and packaging works, without an explicit Trillian test or BVT as both don't run tests against baremetal and the change is a single line change in the baremetal hypervisor plugin.

asfgit pushed a commit that referenced this pull request Nov 25, 2016
CLOUDSTACK-9566 instance-id metadata for baremetal VM returns IDThere is difference in instance-id metadata across baremetal and other hypervisors.

On Baremetal
[root@ip-172-17-0-144 ~]# curl http://8.37.203.221/latest/meta-data/instance-id
6021

on Xen
[root@ip-172-17-2-103 ~]# curl http://172.17.0.252/latest/meta-data/instance-id
cbeb517a-e833-4a0c-b1e8-9ed70200fbbf

In both cases it should be vm's uuid.

* pr/1738:
  CLOUDSTACK-9566 instance-id metadata for baremetal VM returns ID

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@asfgit asfgit merged commit 759a92d into apache:4.8 Nov 25, 2016
lucas-a-martins pushed a commit to scclouds/cloudstack that referenced this pull request Jan 29, 2024
…scclouds'

Atualizar tarifas do Quota com unidade incorreta

Closes apache#1738

See merge request scclouds/scclouds!727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants