[4.9+] CLOUDSTACK-9900: Fix high CPU deviation issues seen in metrics view #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Screenshots: |
DaanHoogland
approved these changes
May 3, 2017
| public void setCpuMaxDeviation(final Double maxCpuUsagePercentage, final Double totalCpuUsedPercentage, final Long totalHosts) { | ||
| if (maxCpuUsagePercentage != null && totalCpuUsedPercentage != null && totalHosts != null && totalHosts != 0) { | ||
| final Double averageCpuUsagePercentage = totalCpuUsedPercentage / totalHosts; | ||
| this.cpuMaxDeviation = String.format("%.2f%%", (maxCpuUsagePercentage - averageCpuUsagePercentage) * 1.0 / averageCpuUsagePercentage); |
There was a problem hiding this comment.
is the '* 1.0' needed when it is devided next? I would rather see a cast if it is, in this case
| public void setCpuMaxDeviation(final Double maxCpuUsagePercentage, final Double totalCpuUsedPercentage, final Long totalHosts) { | ||
| if (maxCpuUsagePercentage != null && totalCpuUsedPercentage != null && totalHosts != null && totalHosts != 0) { | ||
| final Double averageCpuUsagePercentage = totalCpuUsedPercentage / totalHosts; | ||
| this.cpuMaxDeviation = String.format("%.2f%%", (maxCpuUsagePercentage - averageCpuUsagePercentage) * 1.0 / averageCpuUsagePercentage); |
There was a problem hiding this comment.
but i think th '* 1.0' can be removed
HostStats returns cpu usage in percentage while memory usage in bytes. This fixes a regression in maximum CPU usage deviation that did not assume the values to be in percentage and multiple the final ratios with 100 which leads to 100x the actual deviation value. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
force-pushed
the
metrics-view-deviation-fix
branch
from
c81c088
to
efe7646
Compare
|
@DaanHoogland fixed thanks |
|
LGTM |
|
@blueorangutan package |
|
Thanks @rashmidixit for reviewing |
|
LGTM, I already approved but since we have this string in our policy... ;) |
|
LGTM, on code review. |
|
@karuturi can you consider merging this, thanks. |
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
borisstoyanov
approved these changes
May 9, 2017
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-702 |
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-1063)
|
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-725 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HostStats returns cpu usage in percentage while memory usage in bytes.
This fixes a regression in maximum CPU usage deviation that did not
assume the values to be in percentage and multiple the final ratios
with 100 which leads to 100x the actual deviation value.
Pinging for review - @karuturi @DaanHoogland @abhinandanprateek @borisstoyanov @rashmidixit
@blueorangutan package