Iptables speedup #2083
Iptables speedup #2083
Conversation
| @@ -2,6 +2,22 @@ | |||
| # | |||
| # -*- coding: utf-8 -*- | |||
| # | |||
| # Licensed to the Apache Software Foundation (ASF) under one | |||
There was a problem hiding this comment.
this is a big crime of mine. merge must not happen
There was a problem hiding this comment.
I mailed the author of iptables_convert , Johannes Hubertz johannes@hubertz.de, @sl0, and he agreed to publish his code under apache license version2. so I am forgiven.
He has a focus on security and python iptables utilities so I will work with him on the best integration into CloudStack of his code.
There was a problem hiding this comment.
@DaanHoogland any update on this?
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-714 |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Thank you very much for considering to use my iptables_converter.py in Apache CloudStack. Originally it was licensed GPLv3, but I agree to have a copy here under Apache Foundation License, as that is a Free Software License as well. |
|
Trillian test result (tid-1084)
|
|
a lot of errors. need to investigate. see if i screwed up something during rebasing |
|
needs review on failing tests, I'll review once the issues are fixed. thanks. |
|
@DaanHoogland is this still valid, should we consider? The branch has conflicts and need to be rebased. |
|
@DaanHoogland ping |
|
I have no idea nor time to look at those errors. we'll have to rebase and target this for master |
rohityadavcloud
force-pushed
the
iptables-speedup
branch
from
c1a83b1
to
0a813c3
Compare
|
Thanks @sl0, can you re-publish the source file under Apache License 2.0 in your repo that we can use, or send to us as a pull request? |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Hello Rohit,
On 08/19/2017 11:32 PM, Rohit Yadav wrote:
Thanks @sl0 <https://github.com/sl0>, can you re-publish the source file
under Apache License 2.0 in your repo that we can use, or send to us as
a pull request?
You just not want to use the whole package, just part of it. And Daan
asked me th have it with Apache License. I agreed and he has changed in
your repo and I agreed again.
Is this not enough for you? I've put GPL on my sources to prevent them
from been put into a commerial cloesed source project legally. The
inheritance priciple of GPL is very important for me.
FYI: As I worked a long time on it and then continued to have it in
Debian, I'm afraid of changing the license to any other. And today it is
contained in the Debian stretch release, if you like, take it as a
debian package as an external component?
I totally agree to have parts of my iptables-converter within Apache
Cloudstack relicensed to Apache License, but I would be very unhappy to
change GPL on my sources at github, because I'm afraid I have to leave
the Debian Friends...
Thanks for reading, kind regards from Cologne, Germany.
Thank you in advance for any response.
Johannes
(sl0)
|
|
Hello Johannes ( @sl0 ), Regards, Rohit (@rhtyd). |
|
@kiwiflyer this has gone completely from my radar, sorry. I would like to see it in, but have no time to look at it for a while. It is not my code so I'd have to study on it. @sl0's module as a pypi thingy makes sense but to us it will require a refactor of the code, removing the code copy and adding the install in the systemvm build. |
|
@DaanHoogland from what I can see to use iptables-conv verbatim we'd mostly need to
Did I miss s.th.? @sl0 does this sound reasonable? |
|
Hellllo @DaanHoogland and @rhtyd , |
…tables numerous times Conflicts: systemvm/patches/debian/config/opt/cloud/bin/cs/CsAddress.py systemvm/patches/debian/config/opt/cloud/bin/cs/CsNetfilter.py
Conflicts: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py
Conflicts: systemvm/patches/debian/config/opt/cloud/bin/configure.py
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud
force-pushed
the
iptables-speedup
branch
from
b418cdb
to
657e395
Compare
|
Thanks @sl0 I've pulled the updated release, we'll work on refactoring it if needed. |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-1288 |
|
Related for reference: https://github.com/apache/cloudstack/pull/1400/files |
|
Due to lack of activity, I've removed the 4.11 milestone. We can re-engage and work on this for a future minor 4.11.x release. |
|
@DaanHoogland do you think this would make it in 4.11.1? if not we can drop it from the list perhaps? |
|
@borisstoyanov I think let's keep all the tickets marked with 4.11.1.0 as it is. I initially planned to do the iptables speeup changes as part of my vr downtime PR, depending on time/scope. We may bump this to 4.11.2.0 milestone if this does not make into 4.11.1.0 |
No description provided.