-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: add compose file for database #2898
Conversation
I perform my local development with that docker setup and thought I could share it to see if it can help others. Don't hesitate to close it if this is not really needed, or some sort of duplicate. |
@marcaurele how do I test it? I don't use docker for cloudstack development, what commands etc can be used to test it? |
in a terminal : |
@@ -0,0 +1,17 @@ | |||
version: '2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcaurele can license be added to this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I've just pushed the change.
@marcaurele does mariadb 10.x work out of the box, for example mysql 5.7 needs the following config:
Can you check/ensure any additional config to be provided? |
@rhtyd it's maridb 10.0 and not 10.X which is equivalent to mysql 5.6, so there's no need for any extra configuration. It's working out of the box. |
@marcaurele OK, what about the innodb settings?
|
Are those the custom configuration made for CS? |
@marcaurele see install/admin docs, those are recommended mysql settings. The max mysql conn. settings has to do with max job/thread pool size limits. |
pushed another file which is included in the compose to customize the configuration. |
@@ -0,0 +1,7 @@ | |||
[mysqld] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcaurele sorry, license please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it but forgot to add it before pushing. Done!
Thanks, LGTM @marcaurele we just need another review and then we can merge this. |
@rafaelweingartner / @wido / @DaanHoogland / @GabrielBrascher are you using docker for your development? |
Description
A docker-compose file to setup quickly the database for CS. This helps during local development and remove the need to install a local MariaDB/MySQL.
Types of changes
GitHub Issue/PRs
None
Screenshots (if appropriate):
How Has This Been Tested?
docker-compose up
starts the MariaDB 10.0 database for local development.Checklist:
Testing