base64 userdata encoding fix #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are generic for all fields and hurt userdata call ithe existing method remove class that pretends to prevent special chars
5 tasks
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2681 |
rohityadavcloud
approved these changes
Apr 5, 2019
|
No backend tests needed, UI confirmation/test required. |
|
@borisstoyanov I have tested this, but if you can confirm please. |
rohityadavcloud
requested review from
andrijapanicsb,
borisstoyanov and
PaulAngus
dhlaluku
approved these changes
May 6, 2019
|
UI only change, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the cloudstack UI fields get '<', '>' and '&' replaced by xml-entities
these are generic for all fields and hurt us in the case of userdata
this fix calls the existing method to reverse character replacements.
it also removes the ccs class that pretends to prevent special chars
Fixes: #3202
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
This has been tested by creating VMs in the simulator and checking the user_vm.user_data field contents