make sure userdata is correctly passed #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanHoogland
commented
Mar 20, 2019
| @@ -557,7 +557,7 @@ <h3><translate key="label.select.iso.or.template" /></h3> | |||
| <span><translate key="label.add.userdata"/> (<translate key="label.optional"/>)</span> | |||
| </div> | |||
| <div class="value"> | |||
| <textarea name="userdata" class="disallowSpecialCharacters"></textarea> | |||
| <textarea name="userdata"></textarea> | |||
There was a problem hiding this comment.
this might not be needed but it makes no sense either, so I'll keep this in.
DaanHoogland
commented
Mar 20, 2019
ui/scripts/instanceWizard.js
Outdated
| $.extend(deployVmData, { | ||
| userdata : encodeURIComponent(btoa(userdata)) | ||
| userdata : btoa(userdata) |
There was a problem hiding this comment.
I'll re-add the encodeURI call as a base64 string may contain '=' signs.
DaanHoogland
commented
Mar 20, 2019
ui/scripts/instanceWizard.js
Outdated
| userdata = userdata | ||
| .replace(/&/g, "&") | ||
| .replace(/</g, "<") | ||
| .replace(/>/g, ">"); |
There was a problem hiding this comment.
Nicolas reported he had a test case where the calling variity did work, I so I'll experiment more to see if I can get it to work and replace above with a call to cloudstack.sanitizeReverse(userdata);
these are generic for all fields and hurt userdata call ithe existing method remove class that pretends to prevent special chars
DaanHoogland
force-pushed
the
base64-userdata
branch
from
0cbc25d
to
f24b681
Compare
rohityadavcloud
approved these changes
Mar 25, 2019
There was a problem hiding this comment.
LGTM, if testing is okay @DaanHoogland then send to apache/cloudstack
DaanHoogland
changed the title
nvazquez
approved these changes
Apr 1, 2019
|
moved to master |
|
see apache#3260 |
rohityadavcloud
pushed a commit
that referenced
this pull request
Jan 20, 2021
* Added some fixes and made language change not reload * Remove unwanted code Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
shwstppr
added a commit
that referenced
this pull request
Aug 16, 2021
Fixes stopped VM migration of user VM belonging to user other than root admin https://shapeblue.atlassian.net/browse/KDDI-653
shwstppr
added a commit
that referenced
this pull request
Nov 23, 2021
Fixes stopped VM migration of user VM belonging to user other than root admin https://shapeblue.atlassian.net/browse/KDDI-653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
removing class="disallowSpecialCharacters" to prevent url encoding
and calling sanitizeReverse on the fields contents before encoding it to send to the server.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
This has been manually tested by adding user data containing the characters '&', '<' and '>' in the simulator UI and then checking the data base field in the user_vm table to see if the characters where xml-entities after base64-decoding them.