Feature add scss compiler #3299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unnecessary (empty) style definitions
- set minimum heigth of dialog
- center buttons of create form modals - fix width of select menu in service offerings - fix width of modal in Network -> VPC -> configure -> static NAT -> aquire new Ip -> enable static nat
* Fix XenServer Security Groups 'vmops' script
- fix tokens = line.split(':') to tokens = line.split(';')
- fix expected tokens size from 5 to 4
- enhance logs
- remove unused vmops script. The XCP patch points to the vmops script
on the parent folder [1]. Thus, all XenServer versions are considering
the vmops script located at [2].
- fix UI ipv4/ipv6 cidr validator to allow a list of cidirs.
Fixing issue: #3192 Security Group rules not applied at all for
XenServer 6.5 / Advanced Zone
#3192
* Update security group rules after VM migration
Add security group rules on target host
Cause: vmops script expected secondary IPs as "0;" but received "0:"
Remove security group network rules on source host.
Cause: destroy_network_rules_for_vm function on vmops script was not
called when migrating VM
* Add unit tests and address reviewers
* systemd: Fix -Dpid arg passing to systemd usage service This fixes regression introduced by refactoring PR #3163 where `-Dpid` was incorrectly passed string `$$` instead of parent PID integer. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> * fix systemd limitation, exec using /bin/sh instead and wrap in ${} syntax https://www.freedesktop.org/software/systemd/man/systemd.service.html#Command%20lines Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> * usage: don't hide exception from Gabriel's https://github.com/apache/cloudstack/pull/3207/files#diff-062fcf5ae32de59dfd6cd4f780e1d7cd Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: GabrielBrascher <gabriel@pcextreme.nl>
Signed-off-by: GabrielBrascher <gabriel@pcextreme.nl>
* Rename ListUsageRecords API command file name to ListUsageRecordsCmd * Refactor to use APINAME variable and remove unused s_logger field * Remove unused import
Allow users of all types to create L2 guest networks. Fixes #3081
* server: make snapshotting on KVM non-blocking This references and uses an already fixed solution from MissionCriticalCloud/cosmic#68 to make snapshotting on KVM non-blocking. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> * move StorageSubSystemCommand instanceof check above as CopyCommand is a type of StorageSubSystemCommand Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
… using commons-lang version (#3170) NotImplementedException from sun.reflect.generics.reflectiveObjects is not standard/guarateed by the jvm so a custom implementation is in order.
This removes CA certificate button from UI as this is not used and confuses both admin and users how to use it. This may be re-introduced in future when a use-case can be justified. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
With 4.13+ for debian, only systemd enabled distros are supported. This removes an unnecessary dependency. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Hide multiselectaction buttons when selection is resetted after a action is performed Use checked prop instead of attr to show/hide triggered selection when box was clicked by a user before. How to reproduce: Select one entry in a multiSelect listView (e.g. instance list) and then deselect it again. Now click on the "select all" checkbox. The entries which were clicked previously are not displayed as selected. Select at least one entry. Use the multiSelectAction buttons to trigger an action. Wait for completion. The list refreshes and no entry is selected but the multiSelectAction buttons are displayed. Fix: Use "checked" property instead of the attribute to select all entries. This is necessary because when you checked an entry by clicking on it the property gets set and the browser is preferably using this. So setting the attribute by clicking on the "select all" checkbox had no impact anymore on the checkBox of the previously clicked entries. Hide the multiSelectAction buttons when the list is refreshed after an action is performed and no element is selected anymore.
Fixes intermittent failures: - Add a pause to avoid tests restarting before VRs recovering from HA have fully booted. - Add some pauses to allow services to restart and hosts to reconnect before continuing tests. - Adding a loop around this method because sometimes VRs are overloaded and just respond with exception, so it'll catch it and try 5 times with 30sec cooldown. If that fails as well it'll fail the test. - wait until host is up using explicit check
This fixes the issue that TLSv1 and TLSv1.1 are still used by CloudStack management server to communicate with VMware vCenter server. With the current defaults, the setup/deployment on VMware fails. Users/admins can however setup the security file according to their env needs to disable TLSv1 and TLSv1.1 for server sockets (8250/agent service for example). Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This adds empty empty upgrade path from 4.12.0.0 to 4.13.0.0. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
…#3247) This commit makes the API documentation automatically updated to the current project version. If one wants to set another version, it is possible by just editing the ACS_RELEASE variable in 'build-apidoc.sh'.
Problem: When reinstalling a VM, the UI only shows featured templates and not all possible list of allowed templates. Root Cause: The list of templates for reinstall used featured as filter in ‘listTemplates’ API which did not include all available options. Solution: The issue is fixed by using the executable template filter of the ‘listTemplates’ API to list all possible templates that a user is allowed to use to deploy a VM.
## Description The issue was that an Incorrect iscsi path was being passed for managed storage pools when collecting volume stats. Storage pools normally have a UUID based path while managed storage pools require an IQN based path
Using db column instead of VO variable name was causing issue with SQL select statement. This change fixes the problem by using VO variable for adding conditional. Fixes #3208 Using db column instead of VO variable name was causing issue with SQL select statement. This PR fixes the problem by using VO variable for adding conditional. Additionally in UI listAll parameter was being sent twice in the listVMSnapshot API call. It is fixed with this PR. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Problem: When uploading template or iso in a project, the progress is not seen Root Cause: When users upload a template/iso in project view, the template/iso is not visible in the all filter. This creates confusion that template/iso has not been uploaded. Solution: Since the api listtemplates with a projectid acts is a superset of list templates without a project id, we should not ignore the project id when listing templates in all filter.
Problem: Users are billed for destroyed VMs with VM snapshots because usage records don't get that the VM and VM snapshots are removed. Root Cause: The destroyVirtualMachine and expungeVirtualMachine APIs were removing VM snapshots but not generating VMSNAPSHOT.DELETE usage event due to which the VM snapshots were not marked as removed in the usage_vmsnapshot table. Solution: The issue was fixed by emitting the proper usage event for all the VM snapshots of a VM that is destroyed.
Problem: Down arrow key of the vertical scroll bar in the VM deployment wizard does not work. Root Cause: The computer diagram on the right side in the VM deployment wizard spills its margin on the left causing the arrow key to be blocked. Solution: Fix the background-position to get the correct position than margin-left for the zone-panel. With the fix, the left size arrow keys and vertical scrollbars are no longer under the diagram image and press-able now.
* Mock Scanner, instead of scan the computer running the test. This allows non linux machines to run the tests without scanning for a non existing /proc/meminfo. * test fixes on 'other' platforms libvirt wrapper unit tests (#3)
…/NicoWohlfarth/cloudstack into feature_scss_compiler
# Conflicts: # server/src/main/java/com/cloud/network/NetworkServiceImpl.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds gulp tasks, to build existing css files out of scss files and enables many advantages for working with style files. Also this will reduce the complexibility of heavy css files in future.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
This modifies and unifies structure of css code only. All you have to check is, if all of css-code-changes are reduced to: indentation, spaces and quotes.