Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 3 error messages to replace the word 'matches' with 'match' #3982

Merged
merged 2 commits into from
Jun 15, 2020

Conversation

deargopinath
Copy link
Contributor

Description

I provided a fix for the error reported in issue # 3642
Details of the error can be found at:
#3642

Root cause of the problem:
The incorrect error messages were found in the lines 431, 434 and 437 of the file -
server/src/main/java/org/apache/cloudstack/vm/VmImportManagerImpl.java

Line # 431:
throw new ServerApiException ... CPU cores does not matches ...

Line # 434:
throw new ServerApiException ... memory does not matches ...

Line # 437:
throw new ServerApiException ... CPU speed does not matches ...

Changes done to fix the problem:

I replaced the word 'matches' with 'match' inside the 3 error messages.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

I compiled the code after the changes and tested whether the error messages with the updated text are shown for these 3 scenarios of Server API exceptions:

  1. CPU cores not matching
  2. Memory not matching
  3. CPU speed not matching

Thanks to Gabriel Brascher for the review.
Copy link
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @deargopinath, code LGTM.

@DaanHoogland DaanHoogland added this to the 4.15.0.0 milestone Mar 27, 2020
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, string changes

@rohityadavcloud
Copy link
Member

Let's merge this once Travis passes
Fixes #3642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants