-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run #4373
Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run #4373
Conversation
3dea86e
to
bc49564
Compare
@blueorangutan package |
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2123 |
bc49564
to
7c74142
Compare
@blueorangutan package |
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2126 |
@blueorangutan package |
The big question: Why doesn't this exist? I have never seen these issues with Ubuntu systems. |
Ideally this must be created on pkg installation. |
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2161 |
@rhtyd /var/run is a tmpfs on many systems nowadays, so the package can't fix this. I just wonder why we (PCextreme) never run into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this will ensure the folder exists
Manually tested the logic on bash, LGTM. Merging based on travis tests and lgtms. |
I would like to report #4350 fixed create directory issue. thx |
Description
modifyvxlan.sh script fails run as it isn't able to find the /var/run/cloud directory to create the lock file
Fixes: #4350
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?