Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run #4373

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

Pearl1594
Copy link
Contributor

Description

modifyvxlan.sh script fails run as it isn't able to find the /var/run/cloud directory to create the lock file
Fixes: #4350

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

  • Deployed an Advanced zone with VXLAN as isolation method
  • deployed a VM in an isolated network

@Pearl1594 Pearl1594 changed the base branch from master to 4.14 October 5, 2020 13:51
@Pearl1594 Pearl1594 changed the base branch from 4.14 to master October 5, 2020 13:51
@Pearl1594 Pearl1594 changed the title creates /var/run/cloud folder for creation of lock file Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run Oct 5, 2020
@Pearl1594 Pearl1594 changed the base branch from master to 4.14 October 5, 2020 13:59
scripts/vm/network/vnet/modifyvxlan.sh Outdated Show resolved Hide resolved
@DaanHoogland
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2123

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@Pearl1594 Pearl1594 marked this pull request as ready for review October 6, 2020 11:07
@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland added this to the 4.14.1.0 milestone Oct 6, 2020
@blueorangutan
Copy link

Packaging result: ✔centos7 ✖centos8 ✖debian. JID-2126

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@wido
Copy link
Contributor

wido commented Oct 6, 2020

The big question: Why doesn't this exist?

I have never seen these issues with Ubuntu systems.

@rohityadavcloud
Copy link
Member

Ideally this must be created on pkg installation.
@blueorangutan package

@blueorangutan
Copy link

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2161

@wido
Copy link
Contributor

wido commented Oct 12, 2020

@rhtyd /var/run is a tmpfs on many systems nowadays, so the package can't fix this.

I just wonder why we (PCextreme) never run into this.

Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will ensure the folder exists

@rohityadavcloud
Copy link
Member

Manually tested the logic on bash, LGTM. Merging based on travis tests and lgtms.

@levindecaro
Copy link

@DaanHoogland

I would like to report #4350 fixed create directory issue. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modifyvxlan.sh expect /var/run/cloud directory for LOCK, but directory require manual creation
6 participants