-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host is counted twice if it has multiple host tags in Prometheus exporter #4383
Host is counted twice if it has multiple host tags in Prometheus exporter #4383
Conversation
@blueorangutan package |
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2132 |
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2138 |
Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2139 |
@ustcweizhou @DaanHoogland
|
@blueorangutan package |
@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2141 |
Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2147 |
LGTM, changes are strictly in promethus plugin; merging based on lgtms and travis tests. |
Description
If hosts have multiple host tags, the total/up/down hosts in prometheus exporter are not correct.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?