vmware: fix stopped VM volume migration #4758

shwstppr · 2021-03-05T08:58:18Z

Description

Fixes #4674

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Deploy VM with data disk(s)
Stop VM
Migrate ROOT volume of the VM to another storage pool
Start VM <- VM should successfully start

(localcloud) SBCM5> > list virtualmachines id=88afcb03-b3b8-48f1-913a-f9b8224e16d7 
{
  "count": 1,
  "virtualmachine": [
    {
      "account": "admin",
      "affinitygroup": [],
      "cpunumber": 1,
      "cpuspeed": 500,
      "cpuused": "0%",
      "created": "2021-03-26T07:12:40+0000",
      "details": {
        "Message.ReservedCapacityFreed.Flag": "false",
        "cpuOvercommitRatio": "2.0",
        "dataDiskController": "osdefault",
        "memoryOvercommitRatio": "1.0",
        "rootDiskController": "lsilogic"
      },
      "diskioread": 0,
      "diskiowrite": 0,
      "diskkbsread": 0,
      "diskkbswrite": 0,
      "displayname": "t1",
      "displayvm": true,
      "domain": "ROOT",
      "domainid": "f4ba1ec0-8dfe-11eb-a621-1e00d1000368",
      "guestosid": "f4ce8b5a-8dfe-11eb-a621-1e00d1000368",
      "haenable": false,
      "hostid": "0ac50654-1bf1-4dce-ae61-3e303b4ca2bc",
      "hostname": "10.0.33.107",
      "hypervisor": "VMware",
      "id": "88afcb03-b3b8-48f1-913a-f9b8224e16d7",
      "instancename": "i-2-3-VM",
      "isdynamicallyscalable": false,
      "memory": 512,
      "memoryintfreekbs": 5120,
      "memorykbs": 524288,
      "memorytargetkbs": 524288,
      "name": "t1",
      "networkkbsread": 0,
      "networkkbswrite": 0,
      "nic": [
        {
          "broadcasturi": "vlan://1638",
          "extradhcpoption": [],
          "gateway": "10.1.1.1",
          "id": "180a8231-142a-4b41-8970-3db230eb9c7f",
          "ipaddress": "10.1.1.54",
          "isdefault": true,
          "isolationuri": "vlan://1638",
          "macaddress": "02:00:78:cd:00:01",
          "netmask": "255.255.255.0",
          "networkid": "1d953710-bdc5-43d6-be18-2b600a5ec9ee",
          "networkname": "net1",
          "secondaryip": [],
          "traffictype": "Guest",
          "type": "Isolated"
        },
        {
          "broadcasturi": "vlan://1631",
          "extradhcpoption": [],
          "gateway": "10.1.1.1",
          "id": "0734faa4-30da-4ebf-b088-0baeac55387e",
          "ipaddress": "10.1.1.94",
          "isdefault": false,
          "isolationuri": "vlan://1631",
          "macaddress": "02:00:1e:cb:00:01",
          "netmask": "255.255.255.0",
          "networkid": "e5c58088-03d9-41b7-9832-04bfe6ff3da0",
          "networkname": "net2",
          "secondaryip": [],
          "traffictype": "Guest",
          "type": "Isolated"
        }
      ],
      "osdisplayname": "Other Linux (64-bit)",
      "ostypeid": "f4ce8b5a-8dfe-11eb-a621-1e00d1000368",
      "passwordenabled": false,
      "rootdeviceid": 0,
      "rootdevicetype": "ROOT",
      "securitygroup": [],
      "serviceofferingid": "2ced6329-96a0-4bad-bdce-9c004501fb03",
      "serviceofferingname": "Small Instance",
      "state": "Running",
      "tags": [],
      "templatedisplaytext": "ma",
      "templateid": "03a2c29f-9d9e-4d74-ad0f-8888ac1db3f7",
      "templatename": "ma",
      "userid": "0c02b74a-8dff-11eb-a621-1e00d1000368",
      "username": "admin",
      "zoneid": "000fb9f9-6d97-4a6e-860f-1875b8270907",
      "zonename": "pr4758-t268-vmware-65u2"
    }
  ]
}
(localcloud) SBCM5> > list volumes virtualmachineid=88afcb03-b3b8-48f1-913a-f9b8224e16d7 
{
  "count": 2,
  "volume": [
    {
      "account": "admin",
      "chaininfo": "{\"diskDeviceBusName\":\"scsi0:0\",\"diskChain\":[\"[95a458528779364c8d96bd3d35df2392] i-2-3-VM/f239c0a2f9c5492bb81dabcd701fc5ce.vmdk\"]}",
      "clusterid": "1fa7097a-204a-4e19-a827-0b4ebd4a14cf",
      "clustername": "p1-c1",
      "created": "2021-03-26T07:17:38+0000",
      "destroyed": false,
      "deviceid": 0,
      "diskioread": 0,
      "diskiowrite": 0,
      "diskkbsread": 0,
      "diskkbswrite": 0,
      "displayvolume": true,
      "domain": "ROOT",
      "domainid": "f4ba1ec0-8dfe-11eb-a621-1e00d1000368",
      "hypervisor": "VMware",
      "id": "3b449766-aee3-49ee-a34b-b91f8561358d",
      "isextractable": false,
      "name": "ROOT-3-0",
      "path": "f239c0a2f9c5492bb81dabcd701fc5ce",
      "physicalsize": 43319296,
      "podid": "94f99c85-3285-4f0e-876d-f5653f97ade4",
      "podname": "Pod1",
      "provisioningtype": "thin",
      "quiescevm": false,
      "serviceofferingdisplaytext": "Small Instance",
      "serviceofferingid": "2ced6329-96a0-4bad-bdce-9c004501fb03",
      "serviceofferingname": "Small Instance",
      "size": 52428800,
      "state": "Ready",
      "storage": "pr4758-t268-vmware-65u2-esxi-pri1",
      "storageid": "95a45852-8779-364c-8d96-bd3d35df2392",
      "storagetype": "shared",
      "tags": [],
      "templatedisplaytext": "ma",
      "templateid": "03a2c29f-9d9e-4d74-ad0f-8888ac1db3f7",
      "templatename": "ma",
      "type": "ROOT",
      "utilization": "82.6%",
      "virtualmachineid": "88afcb03-b3b8-48f1-913a-f9b8224e16d7",
      "virtualsize": 52428800,
      "vmdisplayname": "t1",
      "vmname": "t1",
      "vmstate": "Running",
      "zoneid": "000fb9f9-6d97-4a6e-860f-1875b8270907",
      "zonename": "pr4758-t268-vmware-65u2"
    },
    {
      "account": "admin",
      "attached": "2021-03-26T07:16:54+0000",
      "chaininfo": "{\"diskDeviceBusName\":\"scsi0:1\",\"diskChain\":[\"[95a458528779364c8d96bd3d35df2392] i-2-3-VM/f2a259f17f644d019ff0f13f2e5db5a0.vmdk\"]}",
      "clusterid": "1fa7097a-204a-4e19-a827-0b4ebd4a14cf",
      "clustername": "p1-c1",
      "created": "2021-03-26T07:16:45+0000",
      "destroyed": false,
      "deviceid": 1,
      "diskioread": 0,
      "diskiowrite": 0,
      "diskkbsread": 0,
      "diskkbswrite": 0,
      "diskofferingdisplaytext": "Small Disk, 5 GB",
      "diskofferingid": "a17dc876-7bf6-4ebb-afa5-205723073343",
      "diskofferingname": "Small",
      "displayvolume": true,
      "domain": "ROOT",
      "domainid": "f4ba1ec0-8dfe-11eb-a621-1e00d1000368",
      "hypervisor": "VMware",
      "id": "548ff64d-5385-41fa-8365-f2593a4551fb",
      "isextractable": true,
      "name": "d1",
      "path": "f2a259f17f644d019ff0f13f2e5db5a0",
      "physicalsize": 0,
      "podid": "94f99c85-3285-4f0e-876d-f5653f97ade4",
      "podname": "Pod1",
      "provisioningtype": "thin",
      "quiescevm": false,
      "size": 5368709120,
      "state": "Ready",
      "storage": "pr4758-t268-vmware-65u2-esxi-pri1",
      "storageid": "95a45852-8779-364c-8d96-bd3d35df2392",
      "storagetype": "shared",
      "tags": [],
      "type": "DATADISK",
      "utilization": "0.0%",
      "virtualmachineid": "88afcb03-b3b8-48f1-913a-f9b8224e16d7",
      "virtualsize": 5368709120,
      "vmdisplayname": "t1",
      "vmname": "t1",
      "vmstate": "Running",
      "zoneid": "000fb9f9-6d97-4a6e-860f-1875b8270907",
      "zonename": "pr4758-t268-vmware-65u2"
    }
  ]
}
(localcloud) SBCM5> > stop virtualmachine id=88afcb03-b3b8-48f1-913a-f9b8224e16d7 
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "cpunumber": 1,
    "cpuspeed": 500,
    "cpuused": "0%",
    "created": "2021-03-26T07:12:40+0000",
    "details": {
      "Message.ReservedCapacityFreed.Flag": "false",
      "cpuOvercommitRatio": "2.0",
      "dataDiskController": "osdefault",
      "memoryOvercommitRatio": "1.0",
      "rootDiskController": "lsilogic"
    },
    "diskioread": 0,
    "diskiowrite": 0,
    "diskkbsread": 0,
    "diskkbswrite": 0,
    "displayname": "t1",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "f4ba1ec0-8dfe-11eb-a621-1e00d1000368",
    "guestosid": "f4ce8b5a-8dfe-11eb-a621-1e00d1000368",
    "haenable": false,
    "hypervisor": "VMware",
    "id": "88afcb03-b3b8-48f1-913a-f9b8224e16d7",
    "instancename": "i-2-3-VM",
    "isdynamicallyscalable": false,
    "jobid": "a97c141d-71b8-452e-859a-28868ac11ddc",
    "jobstatus": 0,
    "memory": 512,
    "memoryintfreekbs": 5120,
    "memorykbs": 524288,
    "memorytargetkbs": 524288,
    "name": "t1",
    "networkkbsread": 0,
    "networkkbswrite": 0,
    "nic": [
      {
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "180a8231-142a-4b41-8970-3db230eb9c7f",
        "ipaddress": "10.1.1.54",
        "isdefault": true,
        "macaddress": "02:00:78:cd:00:01",
        "netmask": "255.255.255.0",
        "networkid": "1d953710-bdc5-43d6-be18-2b600a5ec9ee",
        "networkname": "net1",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      },
      {
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "0734faa4-30da-4ebf-b088-0baeac55387e",
        "ipaddress": "10.1.1.94",
        "isdefault": false,
        "macaddress": "02:00:1e:cb:00:01",
        "netmask": "255.255.255.0",
        "networkid": "e5c58088-03d9-41b7-9832-04bfe6ff3da0",
        "networkname": "net2",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "Other Linux (64-bit)",
    "ostypeid": "f4ce8b5a-8dfe-11eb-a621-1e00d1000368",
    "passwordenabled": false,
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "serviceofferingid": "2ced6329-96a0-4bad-bdce-9c004501fb03",
    "serviceofferingname": "Small Instance",
    "state": "Stopped",
    "tags": [],
    "templatedisplaytext": "ma",
    "templateid": "03a2c29f-9d9e-4d74-ad0f-8888ac1db3f7",
    "templatename": "ma",
    "userid": "0c02b74a-8dff-11eb-a621-1e00d1000368",
    "username": "admin",
    "zoneid": "000fb9f9-6d97-4a6e-860f-1875b8270907",
    "zonename": "pr4758-t268-vmware-65u2"
  }
}
(localcloud) SBCM5> > list storagepools filter=id,name,scope,clusterid,clustername,hypervisor
{
  "count": 2,
  "storagepool": [
    {
      "clusterid": "1fa7097a-204a-4e19-a827-0b4ebd4a14cf",
      "clustername": "p1-c1",
      "id": "4616afa5-447f-3846-bfc9-f7c5108b4c67",
      "name": "pr4758-t268-vmware-65u2-esxi-pri2",
      "scope": "CLUSTER"
    },
    {
      "clusterid": "1fa7097a-204a-4e19-a827-0b4ebd4a14cf",
      "clustername": "p1-c1",
      "id": "95a45852-8779-364c-8d96-bd3d35df2392",
      "name": "pr4758-t268-vmware-65u2-esxi-pri1",
      "scope": "CLUSTER"
    }
  ]
}
(localcloud) SBCM5> > migrate volume volumeid=3b449766-aee3-49ee-a34b-b91f8561358d storageid=4616afa5-447f-3846-bfc9-f7c5108b4c67
{
  "volume": {
    "account": "admin",
    "clusterid": "1fa7097a-204a-4e19-a827-0b4ebd4a14cf",
    "clustername": "p1-c1",
    "created": "2021-03-26T07:53:57+0000",
    "destroyed": false,
    "deviceid": 0,
    "displayvolume": true,
    "domain": "ROOT",
    "domainid": "f4ba1ec0-8dfe-11eb-a621-1e00d1000368",
    "hypervisor": "VMware",
    "id": "3b449766-aee3-49ee-a34b-b91f8561358d",
    "isextractable": false,
    "name": "ROOT-3-0",
    "path": "fc78a63779bb4ee6bce2f5d47b88ea55",
    "podid": "94f99c85-3285-4f0e-876d-f5653f97ade4",
    "podname": "Pod1",
    "provisioningtype": "thin",
    "quiescevm": false,
    "serviceofferingdisplaytext": "Small Instance",
    "serviceofferingid": "2ced6329-96a0-4bad-bdce-9c004501fb03",
    "serviceofferingname": "Small Instance",
    "size": 52428800,
    "state": "Ready",
    "storage": "pr4758-t268-vmware-65u2-esxi-pri2",
    "storageid": "4616afa5-447f-3846-bfc9-f7c5108b4c67",
    "storagetype": "shared",
    "tags": [],
    "templatedisplaytext": "ma",
    "templateid": "03a2c29f-9d9e-4d74-ad0f-8888ac1db3f7",
    "templatename": "ma",
    "type": "ROOT",
    "virtualmachineid": "88afcb03-b3b8-48f1-913a-f9b8224e16d7",
    "vmdisplayname": "t1",
    "vmname": "t1",
    "vmstate": "Stopped",
    "zoneid": "000fb9f9-6d97-4a6e-860f-1875b8270907",
    "zonename": "pr4758-t268-vmware-65u2"
  }
}
(localcloud) SBCM5> > start virtualmachine id=88afcb03-b3b8-48f1-913a-f9b8224e16d7 
{
  "virtualmachine": {
    "account": "admin",
    "affinitygroup": [],
    "cpunumber": 1,
    "cpuspeed": 500,
    "cpuused": "0%",
    "created": "2021-03-26T07:12:40+0000",
    "details": {
      "Message.ReservedCapacityFreed.Flag": "false",
      "cpuOvercommitRatio": "2.0",
      "dataDiskController": "osdefault",
      "memoryOvercommitRatio": "1.0",
      "rootDiskController": "lsilogic"
    },
    "diskioread": 0,
    "diskiowrite": 0,
    "diskkbsread": 0,
    "diskkbswrite": 0,
    "displayname": "t1",
    "displayvm": true,
    "domain": "ROOT",
    "domainid": "f4ba1ec0-8dfe-11eb-a621-1e00d1000368",
    "guestosid": "f4ce8b5a-8dfe-11eb-a621-1e00d1000368",
    "haenable": false,
    "hostid": "0ac50654-1bf1-4dce-ae61-3e303b4ca2bc",
    "hostname": "10.0.33.107",
    "hypervisor": "VMware",
    "id": "88afcb03-b3b8-48f1-913a-f9b8224e16d7",
    "instancename": "i-2-3-VM",
    "isdynamicallyscalable": false,
    "jobid": "445c10a7-cb0f-4c76-8fe5-96f4f48879ed",
    "jobstatus": 0,
    "memory": 512,
    "memoryintfreekbs": 5120,
    "memorykbs": 524288,
    "memorytargetkbs": 524288,
    "name": "t1",
    "networkkbsread": 0,
    "networkkbswrite": 0,
    "nic": [
      {
        "broadcasturi": "vlan://1638",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "180a8231-142a-4b41-8970-3db230eb9c7f",
        "ipaddress": "10.1.1.54",
        "isdefault": true,
        "isolationuri": "vlan://1638",
        "macaddress": "02:00:78:cd:00:01",
        "netmask": "255.255.255.0",
        "networkid": "1d953710-bdc5-43d6-be18-2b600a5ec9ee",
        "networkname": "net1",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      },
      {
        "broadcasturi": "vlan://1631",
        "extradhcpoption": [],
        "gateway": "10.1.1.1",
        "id": "0734faa4-30da-4ebf-b088-0baeac55387e",
        "ipaddress": "10.1.1.94",
        "isdefault": false,
        "isolationuri": "vlan://1631",
        "macaddress": "02:00:1e:cb:00:01",
        "netmask": "255.255.255.0",
        "networkid": "e5c58088-03d9-41b7-9832-04bfe6ff3da0",
        "networkname": "net2",
        "secondaryip": [],
        "traffictype": "Guest",
        "type": "Isolated"
      }
    ],
    "osdisplayname": "Other Linux (64-bit)",
    "ostypeid": "f4ce8b5a-8dfe-11eb-a621-1e00d1000368",
    "passwordenabled": false,
    "rootdeviceid": 0,
    "rootdevicetype": "ROOT",
    "securitygroup": [],
    "serviceofferingid": "2ced6329-96a0-4bad-bdce-9c004501fb03",
    "serviceofferingname": "Small Instance",
    "state": "Running",
    "tags": [],
    "templatedisplaytext": "ma",
    "templateid": "03a2c29f-9d9e-4d74-ad0f-8888ac1db3f7",
    "templatename": "ma",
    "userid": "0c02b74a-8dff-11eb-a621-1e00d1000368",
    "username": "admin",
    "zoneid": "000fb9f9-6d97-4a6e-860f-1875b8270907",
    "zonename": "pr4758-t268-vmware-65u2"
  }
}

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

harikrishna-patnala · 2021-03-05T09:26:36Z

plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java

@@ -2683,15 +2683,14 @@ public Answer deleteVolume(DeleteCommand cmd) {
                        List<VirtualDisk> virtualDisks = vmMo.getVirtualDisks();
                        List<String> managedDatastoreNames = getManagedDatastoreNamesFromVirtualDisks(virtualDisks);

+                        // Preserve other disks of the VM


Thanks for these changes @shwstppr.
Can you please test destroy VM and expunge VM cases with VM having disks. Because this particular block is removed to address disk detachments in case of destroy VM. If those operations are not effected, this looks good to me.

@harikrishna-patnala I've verified the destroy case and have seen any issue.
Will try to share API responses if needed

shwstppr · 2021-03-09T07:15:00Z

@blueorangutan package

blueorangutan · 2021-03-09T07:16:07Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-03-09T07:50:56Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2887

blueorangutan · 2021-03-09T14:39:43Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 60

shwstppr · 2021-03-09T17:20:55Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-03-09T17:22:05Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2021-03-10T03:27:24Z

[S] Trillian test result (tid-64)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37730 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4758-t64-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	786.77	test_kubernetes_clusters.py

blueorangutan · 2021-03-10T04:39:42Z

Trillian test result (tid-3683)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39053 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4758-t3683-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	774.83	test_kubernetes_clusters.py
test_03_migrate_detached_volume	`Error`	74.32	test_vm_life_cycle.py
ContextSuite context=TestVAppsVM>:setup	`Error`	44.34	test_vm_life_cycle.py

shwstppr · 2021-03-10T07:57:21Z

test_03_migrate_detached_volume failure related to #4785

rohityadavcloud · 2021-03-11T08:15:03Z

@nvazquez @harikrishna-patnala can you review this?

nvazquez · 2021-03-22T03:37:48Z

...ns/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java

+                            if (!blankVmCreated) {
+                                throw new Exception("Failed to create VM. vmName: " + vmInternalCSName);
+                            }
+                            deployAsIs = false;


Can you please include a log line explaining why not deploying-as-is in this case? Otherwise will look confusing as the StartCommand may receive deployAsIs = true and not honouring it

@nvazquez I've added a log message. Please see if there needs to be any change in the text.
Also, I've found that systemvms use the same flow with the default systemvm template, i.e., register a blank VM and then start it. Though deployAsIs was already false in that case.

Yes - as long a new system VM template is not registered it uses the non-deploy-as-is behaviour

@shwstppr possible to consider user input through some strictness flag for deployAsIs, and then fallback to not deploying-as-is case if strictness flag is false? (so that user will be aware of it already)

@shwstppr, a small concern here. Since we are starting the VM as not deployAsIs for a VM which is actually a deployAsIs, will there be any problem while applying vApp properties as it is. Can you please test that.

Thanks for pointing it out @harikrishna-patnala . There seem an issue vApp appliances. Re-working on it.

blueorangutan · 2021-03-26T06:22:50Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 264

shwstppr · 2021-03-26T07:51:12Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-03-26T07:52:02Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2021-03-26T18:53:11Z

Trillian test result (tid-271)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38541 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4758-t271-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_deploy_and_upgrade_kubernetes_cluster	`Failure`	777.03	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	79.97	test_kubernetes_clusters.py
ContextSuite context=TestVAppsVM>:setup	`Error`	44.31	test_vm_life_cycle.py

nvazquez · 2021-03-29T17:23:04Z

@blueorangutan package

blueorangutan · 2021-03-29T17:24:03Z

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

shwstppr · 2021-04-13T19:17:17Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-04-13T19:18:02Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

engine/api/src/main/java/com/cloud/vm/VirtualMachineManager.java

engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

...s/vmware/src/main/java/org/apache/cloudstack/storage/motion/VmwareStorageMotionStrategy.java

blueorangutan · 2021-04-14T05:07:16Z

Trillian test result (tid-435)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34275 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4758-t435-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_10_traceroute_in_vr	`Failure`	61.41	test_diagnostics.py

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-04-15T06:58:13Z

@blueorangutan package

blueorangutan · 2021-04-15T06:59:02Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-04-15T07:38:41Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 415

nvazquez

Thanks @shwstppr LGTM

rohityadavcloud · 2021-04-16T09:53:17Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-04-16T09:54:02Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2021-04-16T20:18:00Z

Trillian test result (tid-469)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36360 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4758-t469-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_ping_in_vr_success	`Failure`	15.33	test_diagnostics.py
test_03_ping_in_ssvm_success	`Failure`	15.34	test_diagnostics.py
test_05_ping_in_cpvm_success	`Failure`	15.34	test_diagnostics.py

rohityadavcloud · 2021-04-21T07:18:58Z

@borisstoyanov @nvazquez are you lgtm on this?

nvazquez · 2021-04-21T11:19:36Z

Yes, LGTM after various rounds of review and manual testing

vladimirpetrov

LGTM, tested with both standard template and multi-disk one.

shwstppr · 2021-04-23T15:00:18Z

@blueorangutan package

blueorangutan · 2021-04-23T15:01:02Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2021-04-23T15:22:38Z

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 455

shwstppr · 2021-04-24T02:17:11Z

@blueorangutan test centos7 vmware-67u3

blueorangutan · 2021-04-24T02:18:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

blueorangutan · 2021-04-24T12:02:35Z

Trillian test result (tid-514)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33934 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4758-t514-vmware-67u3.zip
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

prevent other vm disks getting deleted

80f9b4c

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr changed the title ~~Fix vm volmigrate bug~~ vmware: fix stopped VM volume migration Mar 5, 2021

harikrishna-patnala reviewed Mar 5, 2021

View reviewed changes

shwstppr added this to the 4.15.1.0 milestone Mar 9, 2021

shwstppr added the component:vmware label Mar 9, 2021

shwstppr marked this pull request as ready for review March 9, 2021 12:46

shwstppr requested review from rohityadavcloud and nvazquez March 9, 2021 12:48

shwstppr requested a review from harikrishna-patnala March 9, 2021 17:31

rohityadavcloud changed the base branch from master to 4.15 March 18, 2021 09:00

nvazquez reviewed Mar 22, 2021

View reviewed changes

rohityadavcloud requested a review from sureshanaparti March 24, 2021 11:04

rohityadavcloud assigned nvazquez and sureshanaparti Mar 24, 2021

nvazquez reviewed Apr 14, 2021

View reviewed changes

address review comment

5e89cb0

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

nvazquez approved these changes Apr 15, 2021

View reviewed changes

rohityadavcloud requested a review from borisstoyanov April 16, 2021 10:37

shwstppr closed this Apr 23, 2021

shwstppr reopened this Apr 23, 2021

vladimirpetrov self-requested a review April 23, 2021 14:52

vladimirpetrov approved these changes Apr 23, 2021

View reviewed changes

shwstppr closed this Apr 23, 2021

shwstppr reopened this Apr 23, 2021

rohityadavcloud merged commit a30d518 into apache:4.15 Apr 24, 2021

rohityadavcloud mentioned this pull request Apr 24, 2021

vmware: vm operations fail after ROOT volume migration #4674

Closed

shwstppr mentioned this pull request Jul 22, 2021

Migration not working in ACS 4.14 with Basic Network - VMware Local storage #4187

Closed

vmware: fix stopped VM volume migration #4758

vmware: fix stopped VM volume migration #4758

Conversation

shwstppr commented Mar 5, 2021 • edited Loading

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

harikrishna-patnala Mar 5, 2021

Choose a reason for hiding this comment

shwstppr Mar 9, 2021

Choose a reason for hiding this comment

shwstppr commented Mar 9, 2021

blueorangutan commented Mar 9, 2021

blueorangutan commented Mar 9, 2021

blueorangutan commented Mar 9, 2021

shwstppr commented Mar 9, 2021

blueorangutan commented Mar 9, 2021

blueorangutan commented Mar 10, 2021

blueorangutan commented Mar 10, 2021

shwstppr commented Mar 10, 2021

rohityadavcloud commented Mar 11, 2021

nvazquez Mar 22, 2021 • edited Loading

Choose a reason for hiding this comment

shwstppr Mar 26, 2021

Choose a reason for hiding this comment

nvazquez Mar 29, 2021

Choose a reason for hiding this comment

sureshanaparti Mar 30, 2021 • edited Loading

Choose a reason for hiding this comment

harikrishna-patnala Apr 1, 2021

Choose a reason for hiding this comment

shwstppr Apr 1, 2021

Choose a reason for hiding this comment

blueorangutan commented Mar 26, 2021

shwstppr commented Mar 26, 2021

blueorangutan commented Mar 26, 2021

blueorangutan commented Mar 26, 2021

nvazquez commented Mar 29, 2021

blueorangutan commented Mar 29, 2021

shwstppr commented Apr 13, 2021

blueorangutan commented Apr 13, 2021

blueorangutan commented Apr 14, 2021

shwstppr commented Apr 15, 2021

blueorangutan commented Apr 15, 2021

blueorangutan commented Apr 15, 2021

nvazquez left a comment

Choose a reason for hiding this comment

rohityadavcloud commented Apr 16, 2021

blueorangutan commented Apr 16, 2021

blueorangutan commented Apr 16, 2021

rohityadavcloud commented Apr 21, 2021

nvazquez commented Apr 21, 2021

vladimirpetrov left a comment

Choose a reason for hiding this comment

shwstppr commented Apr 23, 2021

blueorangutan commented Apr 23, 2021

blueorangutan commented Apr 23, 2021

shwstppr commented Apr 24, 2021

blueorangutan commented Apr 24, 2021

blueorangutan commented Apr 24, 2021

shwstppr commented Mar 5, 2021 •

edited

Loading

nvazquez Mar 22, 2021 •

edited

Loading

sureshanaparti Mar 30, 2021 •

edited

Loading