Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Support to upload resource icons #5157

Merged
merged 44 commits into from
Sep 15, 2021
Merged

UI: Support to upload resource icons #5157

merged 44 commits into from
Sep 15, 2021

Conversation

Pearl1594
Copy link
Contributor

@Pearl1594 Pearl1594 commented Jun 25, 2021 •
edited
Loading

Description

This PR provides support for adding resource icons/ images for Zones, templates, ISOs, UserVMs, Networks, VPCs, Domains, Projects, Accounts and users which will helps users/admins in future to identify special-purpose templates and VMs using custom icons in UI. Some of the attributes of this feature includes:

  • Users will inherit the account's icon if not present.

  • Isolated networks tiers of a VPC network will inherit the Icon of the VPC network if present.

  • Resources that support uploading custom icons have a small symbol image against the logo.

  • Users with permission to access resources can upload/update and delete the icons. If no icons have been provided, it follows the normal behavior. Info Card view will also display the corresponding resource's icons if present.

  • The Deploy VM wizard will show the list of zones in the form of cards in the number of zones are <= 8
    image
    Else, it defaults to the usual list view but will display the icon beside the zone name

  • The capacity dashboard view will also display the zone icons beside the zone names as shown above

  • The project list view (Used for switching to different projects available, on the Dashboard page) will also list the project icons beside the project names
    test4

  • List view of all resources that support resource icons will now display the icons beside the name

  • The user/account icon will be displayed at the top right corner of the landing / dashboard page
    test3

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 364

@DaanHoogland
Copy link
Contributor

\o/

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 390

@Pearl1594
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1131)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39755 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t1131-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Smoke tests completed. 87 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_02_deploy_and_upgrade_kubernetes_cluster Failure 443.47 test_kubernetes_clusters.py

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 423

@Pearl1594
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1158)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49714 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t1158-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_primary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 83 look OK, 5 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_01_create_lb_rule_src_nat Failure 617.96 test_loadbalance.py
test_02_create_lb_rule_non_nat Failure 77.50 test_loadbalance.py
test_assign_and_removal_lb Failure 75.30 test_loadbalance.py
test_01_add_primary_storage_disabled_host Error 0.55 test_primary_storage.py
test_01_primary_storage_nfs Error 0.16 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.23 test_primary_storage.py
test_02_list_snapshots_with_removed_data_store Error 1.16 test_snapshots.py
test_01_secure_vm_migration Error 148.71 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 266.16 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 140.58 test_vm_life_cycle.py
test_08_migrate_vm Error 43.70 test_vm_life_cycle.py
test_hostha_kvm_host_fencing Error 712.36 test_hostha_kvm.py

@Pearl1594
Added support for the following:
301310c 
resource icon support for vpcs, networks, domains, and projects
add icons to list view if reosurces support icons to be added
support for showing project icons in the project switching drop-down menu
@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1174

@Pearl1594
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-1991)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33933 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t1991-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

Trillian test result (tid-1990)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34141 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t1990-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@Pearl1594 Pearl1594 marked this pull request as ready for review September 9, 2021 12:35
@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1196

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1228

@blueorangutan
Copy link

Packaging result: ✖️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1227

@Pearl1594
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 1232

@Pearl1594
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@rohityadavcloud
Copy link
Member

LGTM - this has passed manual and smoketests + 2xLGTMs; can be merged after the final smoketests run.

@blueorangutan
Copy link

Trillian test result (tid-2035)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36515 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5157-t2035-kvm-centos7.zip
Smoke tests completed. 89 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

nvazquez
nvazquez approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez merged commit 3f827ef into apache:main Sep 15, 2021
@rohityadavcloud
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@shwstppr shwstppr shwstppr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@vladimirpetrov vladimirpetrov vladimirpetrov approved these changes

Assignees
No one assigned
Labels
component:UI type:new-feature
Projects
None yet
Milestone
4.16.0.0
Development

Successfully merging this pull request may close these issues.
9 participants
@Pearl1594 @blueorangutan @DaanHoogland @vladimirpetrov @alexandremattioli @rohityadavcloud @shwstppr @nvazquez @sureshanaparti