Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Honour isrecursive above listall" #6126

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Revert "Honour isrecursive above listall" #6126

merged 1 commit into from
Mar 17, 2022

Conversation

nvazquez
Copy link
Contributor

Reverts #6045

Have found some regressions after merging this PR, reverting so we can fix properly

@nvazquez nvazquez added this to the 4.17.0.0 milestone Mar 16, 2022
@davidjumani davidjumani mentioned this pull request Mar 16, 2022
Closed
10 tasks
@nvazquez nvazquez mentioned this pull request Mar 16, 2022
Closed
10 tasks
weizhouapache
weizhouapache approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on revert

@nvazquez
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2905

@nvazquez
Copy link
Contributor Author

@blueorangutan test

@blueorangutan
Copy link

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez nvazquez mentioned this pull request Mar 16, 2022
Merged
10 tasks
@blueorangutan
Copy link

Trillian test result (tid-3639)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33010 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6126-t3639-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File
test_hostha_enable_ha_when_host_disabled Error 1.73 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 303.78 test_hostha_kvm.py

@nvazquez nvazquez merged commit 3fc31ca into main Mar 17, 2022
@weizhouapache weizhouapache mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@davidjumani davidjumani Awaiting requested review from davidjumani

Assignees
No one assigned
Labels
type:regression
Projects
No open projects
Apache CloudStack 4.17.0
Status: Done
Milestone
4.17.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nvazquez @blueorangutan @Pearl1594 @weizhouapache