Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VR: add '-m <protocol>' for tcp or udp protocol #6188

Merged
merged 1 commit into from
Apr 6, 2022
Merged

VR: add '-m <protocol>' for tcp or udp protocol #6188

merged 1 commit into from
Apr 6, 2022

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes missing "-m tcp" or "-m udp" which cause some networking issues.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3042

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland
DaanHoogland reviewed Apr 1, 2022
View reviewed changes
systemvm/debian/opt/cloud/bin/configure.py
@@ -162,6 +162,7 @@ def add_rule(self):
" -A FIREWALL_%s" % self.ip +
" -s %s " % cidr +
" -p %s " % rule['protocol'] +
" -m %s " % rule['protocol'] +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should start using format strings

Suggested change
" -m %s " % rule['protocol'] +
" -m {rule['protocol']} " +

not a biggy or in scope for this PR, just a thought on systemvm python code in general.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. add to idea board ?

DaanHoogland
DaanHoogland approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Member Author

@blueorangutan test

1 similar comment
@nvazquez
Copy link
Contributor

nvazquez commented Apr 1, 2022

@blueorangutan test

@nvazquez nvazquez added this to the 4.17.0.0 milestone Apr 1, 2022
@blueorangutan
Copy link

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@nvazquez
Copy link
Contributor

nvazquez commented Apr 5, 2022

@blueorangutan test

@blueorangutan
Copy link

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3076

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link

Trillian test result (tid-3815)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32060 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6188-t3815-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link

Trillian test result (tid-3822)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 378 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6188-t3822-kvm-centos7.zip
Smoke tests completed. 0 look OK, 1 have errors
Only failed tests results shown below:

Test Result Time (s) Test File

nvazquez
nvazquez approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvazquez nvazquez merged commit 47454ec into apache:4.16 Apr 6, 2022
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @rohityadavcloud
VR: add '-m <protocol>' for tcp or udp protocol (apache#6188)
eecd703 
(cherry picked from commit 47454ec)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @rohityadavcloud
VR: add '-m <protocol>' for tcp or udp protocol (apache#6188)
d08d3fb 
(cherry picked from commit 47454ec)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @rohityadavcloud
VR: add '-m <protocol>' for tcp or udp protocol (apache#6188)
ba4b0ff 
(cherry picked from commit 47454ec)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @rohityadavcloud
VR: add '-m <protocol>' for tcp or udp protocol (apache#6188)
f2853d0 
(cherry picked from commit 47454ec)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
rohityadavcloud pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022
@weizhouapache @rohityadavcloud
VR: add '-m <protocol>' for tcp or udp protocol (apache#6188)
7398915 
(cherry picked from commit 47454ec)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@weizhouapache weizhouapache deleted the 4.16-vr-add-m-tcp branch December 9, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@nvazquez nvazquez nvazquez approved these changes

Assignees
No one assigned
Labels
component:virtual-router type:bug
Projects
No open projects
Apache CloudStack 4.17.0
Status: Done
Milestone
4.17.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@weizhouapache @blueorangutan @nvazquez @DaanHoogland