Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fixes ui error when upgrade virtual routers from virtual router list #6468

Merged
merged 1 commit into from
Jun 20, 2022
Merged

UI: Fixes ui error when upgrade virtual routers from virtual router list #6468

merged 1 commit into from
Jun 20, 2022

Conversation

utchoang
Copy link

@utchoang utchoang commented Jun 17, 2022 •
edited
Loading

Description

This PR fixes #6466

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@utchoang utchoang changed the base branch from main to 4.17 June 17, 2022 01:55
@acs-robot
Copy link
Collaborator

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan
Copy link

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6468 (SL-JID-1752)

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@utchoang
Copy link
Author

utchoang commented Jun 17, 2022 •
edited
Loading

I see the response of upgradeRouterTemplate API does not contain the jobId but adds 1 more level of asyncjobs so the upgrade is still in the progress state. (below image)
image
image

@nvazquez nvazquez added this to the 4.17.1.0 milestone Jun 17, 2022
weizhouapache
weizhouapache approved these changes Jun 17, 2022
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kohrar
Copy link
Contributor

kohrar commented Jun 17, 2022

The fix seems to work for me. Thanks @utchoang

@rohityadavcloud rohityadavcloud merged commit 15c4dcf into apache:4.17 Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees
No one assigned
Labels
component:UI type:bug
Projects
None yet
Milestone
4.17.1.0
Development

Successfully merging this pull request may close these issues.

UI - Cannot mass upgrade virtual routers from virtual router list
8 participants
@utchoang @acs-robot @blueorangutan @kohrar @shwstppr @weizhouapache @rohityadavcloud @nvazquez