server: remove resource tags for disassociated public ip

[shwstppr]

Description

Fixes #6620

Remove resource tags when public IP is disassociated

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[shwstppr]

@blueorangutan package

[blueorangutan]

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6642 (SL-JID-2155)

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3996

[shwstppr]

@blueorangutan test

[blueorangutan]

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[codecov]

Codecov Report

Merging #6642 (2799eca) into 4.17 (9410a70) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               4.17    #6642      +/-   ##
============================================
- Coverage      5.86%    5.86%   -0.01%     
  Complexity     3918     3918              
============================================
  Files          2451     2451              
  Lines        242257   242258       +1     
  Branches      37907    37907              
============================================
  Hits          14207    14207              
- Misses       226480   226481       +1     
  Partials       1570     1570              

Impacted Files	Coverage Δ
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[blueorangutan]

Trillian test result (tid-4702)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36946 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6642-t4702-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File