Fixed the management server setup line #6822
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
| print("Please ensure the following ports are open for the management server to function properly : 8080 8250 8443 9090") | ||
| print("CloudStack Management Server setup is Done!") | ||
| print("You can now log into CloudStack UI") | ||
| print("Management Server uses following ports to function properly: 8080 8250 8443 9090") |
There was a problem hiding this comment.
I would prefer a WARNING here
There was a problem hiding this comment.
I think this is not logging but printing on the console when cloudstack-setup-management is run.
@rahulbcn27 I think the line can be improved to still suggest that the (a) ports must be open and not firewalled, and (b) not in use by other processes on the host.
There was a problem hiding this comment.
Thanks Rohit for the suggestion. I have made the changes proposed. Please check it.
Codecov Report
@@ Coverage Diff @@
## main #6822 +/- ##
============================================
+ Coverage 10.84% 10.87% +0.02%
- Complexity 7104 7118 +14
============================================
Files 2485 2485
Lines 245417 245507 +90
Branches 38326 38334 +8
============================================
+ Hits 26627 26710 +83
- Misses 215521 215526 +5
- Partials 3269 3271 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@blueorangutan package |
|
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. LL-JID 196 |
|
@blueorangutan test |
|
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-40)
|
Co-authored-by: Rohit Yadav <rohityadav89@gmail.com>
rahulbcn27
requested review from
rohityadavcloud and
weizhouapache
and removed request for
weizhouapache and
rohityadavcloud
|
@blueorangutan package |
|
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress. |
|
Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4634 |
|
@blueorangutan test |
|
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian Build Failed (tid-5256) |
|
@rahulbcn27 can you add a test description, please? |
sorry never mind, this is not really a functional change... (guess I was tired/it was late) |
There was a problem hiding this comment.
@rahulbcn27 , please consider @stephankruggg 's suggestion which looks good
Co-authored-by: Stephan Krug <stekrug@icloud.com>
|
Awesome work, congrats on your first merged pull request! |
Description
This PR is for changing the line printed as : "Please ensure the following ports are open for the management server to function properly : 8080 8250 8443 9090" to more understandable lines. The above line was misleading , so it was changed to new lines :
This happens after the management server is setup. Behaviour functionally has not changed at all. Only,meaning of the lines printed has changed.
The behavior Functionally has not changed at all.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
This has been tested on local environment.
Trivial Normal tests were done , that is usually done when source code is compiled and management server is started.