Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: fix add zone dialog for fix errors #7201

Merged
merged 1 commit into from
Feb 13, 2023
Merged

ui: fix add zone dialog for fix errors #7201

merged 1 commit into from
Feb 13, 2023

Conversation

shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Feb 13, 2023 •
edited
Loading

Description

Fixes #7194

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

fix-errors-add-dialog.mp4

How Has This Been Tested?

@shwstppr
ui: fix add zone dialog for fix errors
d518118 
Fixes apache#7194

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@DaanHoogland DaanHoogland added this to the 4.18.0.0 milestone Feb 13, 2023
@shwstppr
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7201 (QA-JID-45)

nvazquez
nvazquez approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - manually tested adding an invalid zone, Fix errors gets back to the previous steps to fix the issues

@DaanHoogland
Copy link
Contributor

LGTM - manually tested adding an invalid zone, Fix errors gets back to the previous steps to fix the issues

same here, tested in qa and code looks good

@DaanHoogland DaanHoogland removed the request for review from vladimirpetrov February 13, 2023 12:06
@DaanHoogland DaanHoogland merged commit f2d1a34 into apache:main Feb 13, 2023
@weizhouapache
Copy link
Member

verified ok.

@DaanHoogland DaanHoogland deleted the fix-zone-dialog-fix-errors branch February 13, 2023 12:20
@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@nvazquez nvazquez nvazquez approved these changes

Assignees
No one assigned
Labels
component:UI
Projects
None yet
Milestone
4.18.0.0
Development

Successfully merging this pull request may close these issues.

No way to fix errors after a failure on 'Add zone' dialog
6 participants
@shwstppr @blueorangutan @DaanHoogland @weizhouapache @nvazquez @vladimirpetrov