Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding root disk offering & size, and expunge old root disk while restoring a VM #8800

Merged
merged 14 commits into from
Apr 12, 2024

Resolve comments

ec0790c
Select commit
Failed to load commit list.
Merged

Allow overriding root disk offering & size, and expunge old root disk while restoring a VM #8800

Resolve comments
ec0790c
Select commit
Failed to load commit list.
Codecov / codecov/patch succeeded Mar 29, 2024 in 0s

57.14% of diff hit (target 30.99%)

View this Pull Request on Codecov

57.14% of diff hit (target 30.99%)

Annotations

Check warning on line 5632 in engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java#L5632

Added line #L5632 was not covered by tests

Check warning on line 7652 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L7652

Added line #L7652 was not covered by tests

Check warning on line 7671 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L7669-L7671

Added lines #L7669 - L7671 were not covered by tests

Check warning on line 7673 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L7673

Added line #L7673 was not covered by tests

Check warning on line 7839 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L7838-L7839

Added lines #L7838 - L7839 were not covered by tests

Check warning on line 7842 in server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

server/src/main/java/com/cloud/vm/UserVmManagerImpl.java#L7842

Added line #L7842 was not covered by tests