Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding root disk offering & size, and expunge old root disk while restoring a VM #8800

Merged
merged 14 commits into from
Apr 12, 2024

Resolve comments

ec0790c
Select commit
Loading
Failed to load commit list.
Merged

Allow overriding root disk offering & size, and expunge old root disk while restoring a VM #8800

Resolve comments
ec0790c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Mar 29, 2024 in 0s

30.90% (-0.10%) compared to 0043540

View this Pull Request on Codecov

30.90% (-0.10%) compared to 0043540

Details

Codecov Report

Attention: Patch coverage is 57.14286% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 30.90%. Comparing base (0043540) to head (ec0790c).
Report is 12 commits behind head on 4.19.

Files Patch % Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java 44.44% 9 Missing and 6 partials ⚠️
...e/cloudstack/api/command/user/vm/RestoreVMCmd.java 33.33% 0 Missing and 2 partials ⚠️
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #8800      +/-   ##
============================================
- Coverage     30.99%   30.90%   -0.10%     
+ Complexity    34369    34272      -97     
============================================
  Files          5355     5355              
  Lines        376630   376715      +85     
  Branches      54807    54822      +15     
============================================
- Hits         116741   116412     -329     
- Misses       244535   244947     +412     
- Partials      15354    15356       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov