Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add search filters #9068

Merged
merged 20 commits into from
May 28, 2024
Merged

Conversation

vishesh92
Copy link
Member

Description

This PR fixes #7218

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Member Author

@blueorangutan ui

@vishesh92 vishesh92 linked an issue May 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.30%. Comparing base (ea9a0f4) to head (d5092d0).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #9068       +/-   ##
============================================
- Coverage     14.96%   4.30%   -10.67%     
============================================
  Files          5373     363     -5010     
  Lines        469024   29293   -439731     
  Branches      58818    5115    -53703     
============================================
- Hits          70197    1260    -68937     
+ Misses       391056   27891   -363165     
+ Partials       7771     142     -7629     
Flag Coverage Δ
uitests 4.30% <ø> (-0.02%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9068 (QA-JID-340)

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good and filters show in qa (and work wherever I tried)

Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@DaanHoogland DaanHoogland added this to the 4.19.1.0 milestone May 28, 2024
@DaanHoogland DaanHoogland merged commit ad66edf into apache:4.19 May 28, 2024
22 of 25 checks passed
@DaanHoogland DaanHoogland deleted the ui-add-search-filters branch May 28, 2024 05:39
DaanHoogland added a commit that referenced this pull request May 28, 2024
* 4.19:
  engine-schema: add removed columne for cloud.user_data, fix delete op (#9120)
  ui: fix create menu item access (#9104)
  server: honor listall param for listiso api (#9064)
  ui: add move to top/bottom for acl rules list (#9119)
  ui: fix columns for exportacls csv (#9118)
  ui: fix create network access in deploy vm wizard (#9117)
  UI: Add search filters (#9068)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
* 4.19:
  engine-schema: add removed columne for cloud.user_data, fix delete op (apache#9120)
  ui: fix create menu item access (apache#9104)
  server: honor listall param for listiso api (apache#9064)
  ui: add move to top/bottom for acl rules list (apache#9119)
  ui: fix columns for exportacls csv (apache#9118)
  ui: fix create network access in deploy vm wizard (apache#9117)
  UI: Add search filters (apache#9068)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Filter option is missing for the following tabs in the UI
4 participants