Use final

Use compact array notation
apache · Apr 21, 2024 · 7ae5745 · 7ae5745
1 parent f670f11
commit 7ae5745
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/src/main/java/org/apache/bcel/classfile/DescendingVisitor.java b/src/main/java/org/apache/bcel/classfile/DescendingVisitor.java
@@ -505,15 +505,15 @@ public void visitParameterAnnotationEntry(final ParameterAnnotationEntry obj) {
     }
 
     @Override
-    public void visitRecord(Record record) {
+    public void visitRecord(final Record record) {
         stack.push(record);
         record.accept(visitor);
         accept(record.getComponents());
         stack.pop();
     }
 
     @Override
-    public void visitRecordComponent(RecordComponentInfo recordComponentInfo) {
+    public void visitRecordComponent(final RecordComponentInfo recordComponentInfo) {
         stack.push(recordComponentInfo);
         recordComponentInfo.accept(visitor);
         stack.pop();

diff --git a/src/main/java/org/apache/bcel/classfile/Record.java b/src/main/java/org/apache/bcel/classfile/Record.java
@@ -35,7 +35,7 @@
  */
 public final class Record extends Attribute {
 
-    private static final RecordComponentInfo[] EMPTY_RCI_ARRAY = new RecordComponentInfo[] {};
+    private static final RecordComponentInfo[] EMPTY_RCI_ARRAY = {};
 
     private static RecordComponentInfo[] readComponents(final DataInput input, final ConstantPool constantPool)
             throws IOException {

diff --git a/src/main/java/org/apache/bcel/classfile/RecordComponentInfo.java b/src/main/java/org/apache/bcel/classfile/RecordComponentInfo.java
@@ -44,7 +44,7 @@ public class RecordComponentInfo implements Node {
      * @param constantPool Array of constants
      * @throws IOException if an I/O error occurs.
      */
-    public RecordComponentInfo(final DataInput input, ConstantPool constantPool) throws IOException {
+    public RecordComponentInfo(final DataInput input, final ConstantPool constantPool) throws IOException {
         this.index = input.readUnsignedShort();
         this.descriptorIndex = input.readUnsignedShort();
         final int attributesCount = input.readUnsignedShort();
@@ -56,7 +56,7 @@ public RecordComponentInfo(final DataInput input, ConstantPool constantPool) thr
     }
 
     @Override
-    public void accept(Visitor v) {
+    public void accept(final Visitor v) {
         v.visitRecordComponent(this);
     }
 
@@ -66,7 +66,7 @@ public void accept(Visitor v) {
      * @param file Output file stream
      * @throws IOException if an I/O error occurs.
      */
-    public void dump(DataOutputStream file) throws IOException {
+    public void dump(final DataOutputStream file) throws IOException {
         file.writeShort(index);
         file.writeShort(descriptorIndex);
         file.writeShort(attributes.length);

diff --git a/src/main/java/org/apache/bcel/classfile/Visitor.java b/src/main/java/org/apache/bcel/classfile/Visitor.java
@@ -234,7 +234,7 @@ default void visitRecord(final Record obj) {
      * @param record component to visit
      * @since 6.9.0
      */
-    default void visitRecordComponent(RecordComponentInfo record) {
+    default void visitRecordComponent(final RecordComponentInfo record) {
      // noop
     }
 

diff --git a/src/main/java/org/apache/bcel/verifier/statics/StringRepresentation.java b/src/main/java/org/apache/bcel/verifier/statics/StringRepresentation.java
@@ -400,12 +400,12 @@ public void visitParameterAnnotationEntry(final ParameterAnnotationEntry obj) {
     }
 
     @Override
-    public void visitRecord(Record obj) {
+    public void visitRecord(final Record obj) {
         tostring = toString(obj);
     }
 
     @Override
-    public void visitRecordComponent(RecordComponentInfo obj) {
+    public void visitRecordComponent(final RecordComponentInfo obj) {
         tostring = toString(obj);
     }
 

diff --git a/src/test/java/org/apache/bcel/generic/InstructionFactoryTestCase.java b/src/test/java/org/apache/bcel/generic/InstructionFactoryTestCase.java
@@ -64,7 +64,7 @@ public void testArrayStore() throws Exception {
 
     @Test
     public void testCreateInvokeNullArgTypes() throws Exception {
-        InstructionFactory factory = new InstructionFactory(new ClassGen(Repository.lookupClass(Object.class)));
+        final InstructionFactory factory = new InstructionFactory(new ClassGen(Repository.lookupClass(Object.class)));
         factory.createInvoke("", "", Type.VOID, null, Const.INVOKESPECIAL, false); // Mustn't throw an NPE
     }
 

diff --git a/src/test/java/org/apache/bcel/visitors/CountingVisitor.java b/src/test/java/org/apache/bcel/visitors/CountingVisitor.java
@@ -490,12 +490,12 @@ public void visitParameterAnnotationEntry(final ParameterAnnotationEntry paramet
     }
 
     @Override
-    public void visitRecord(Record v) {
+    public void visitRecord(final Record v) {
         recordCount++;
     }
 
     @Override
-    public void visitRecordComponent(RecordComponentInfo v) {
+    public void visitRecordComponent(final RecordComponentInfo v) {
         recordComponentCount++;
     }