Skip to content

Commit

Permalink
JaCoCo on Java 8 is different from other versions
Browse files Browse the repository at this point in the history
  • Loading branch information
garydgregory committed Apr 21, 2024
1 parent 5dbc07f commit fd77840
Showing 1 changed file with 10 additions and 18 deletions.
28 changes: 10 additions & 18 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,16 @@
<assertj.version>3.25.3</assertj.version>
<jna.version>5.14.0</jna.version>
<japicmp.skip>false</japicmp.skip>
<commons.jacoco.haltOnFailure>false</commons.jacoco.haltOnFailure>
<commons.jacoco.haltOnFailure>true</commons.jacoco.haltOnFailure>

<!-- JaCoCo on Java 8 is different from other versions. On JDK9+ there is a profile -->
<!-- JaCoCo: Don't make code coverage worse than: -->
<commons.jacoco.classRatio>0.89</commons.jacoco.classRatio>
<commons.jacoco.instructionRatio>0.65</commons.jacoco.instructionRatio>
<commons.jacoco.methodRatio>0.70</commons.jacoco.methodRatio>
<commons.jacoco.branchRatio>0.59</commons.jacoco.branchRatio>
<commons.jacoco.lineRatio>0.68</commons.jacoco.lineRatio>
<commons.jacoco.complexityRatio>0.58</commons.jacoco.complexityRatio>
</properties>

<distributionManagement>
Expand Down Expand Up @@ -519,23 +528,6 @@
</plugins>
</build>
</profile>
<profile>
<!-- Java 8 only -->
<id>java-8</id>
<activation>
<jdk>8</jdk>
</activation>
<properties>
<!-- JaCoCo on Java 8 is different from other versions. -->
<!-- JaCoCo: Don't make code coverage worse than: -->
<commons.jacoco.classRatio>0.89</commons.jacoco.classRatio>
<commons.jacoco.instructionRatio>0.65</commons.jacoco.instructionRatio>
<commons.jacoco.methodRatio>0.70</commons.jacoco.methodRatio>
<commons.jacoco.branchRatio>0.59</commons.jacoco.branchRatio>
<commons.jacoco.lineRatio>0.68</commons.jacoco.lineRatio>
<commons.jacoco.complexityRatio>0.58</commons.jacoco.complexityRatio>
</properties>
</profile>
<profile>
<!-- Java 9 and up -->
<id>java-9-up</id>
Expand Down

0 comments on commit fd77840

Please sign in to comment.