Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BCEL-323]BCELifier to set major and minor versions #31

Merged
merged 2 commits into from Jul 10, 2019

Conversation

suztomo
Copy link
Contributor

@suztomo suztomo commented Jul 10, 2019

The continuous integration builds have been failing for JDK 13 (build history).

  • The failing test was comparing the output of javap command. JDK 13's javap outputs "default" if major.minor >= 52.0 (OpenJDK's commit in June 2019)
  • BCELifer was not copying major minor (default 45.3).

See BCEL-323 for details.

Now the build succeeds:

image

Copy link
Member

@garydgregory garydgregory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suztomo
Would you mind updating changes.xml as well. This will save me some busywork ;-)
TY,
Gary

@suztomo
Copy link
Contributor Author

suztomo commented Jul 10, 2019

Updated changes.xml.

@garydgregory garydgregory merged commit ba69ce3 into apache:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants