Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global: make use of FunctionalInterface #48

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

grimreaper
Copy link
Member

Now that we're using Java 8, it seems reasonable to annotate.

@grimreaper grimreaper force-pushed the eax/finter/now branch 2 times, most recently from 44a8891 to a808eb5 Compare July 27, 2018 11:04
@soc
Copy link

soc commented Jul 28, 2018

@grimreaper Would it make sense in general to also annotate interfaces that just duplicate the ones in java.util.function with @Deprecated?

@grimreaper
Copy link
Member Author

IMHO yes, though that should be done separately.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I think it doesn't break backward compatibility, and would indicate that it is indeed a functional interface, make sure it keeps being one (i.e. no more methods added without an error).

Let's see what others think, but +1 from me 👍

Now that we're using Java 8, it seems reasonable to annotate.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.824% when pulling 598a42b on grimreaper:eax/finter/now into ca6851e on apache:master.

@garydgregory garydgregory merged commit dea6dfa into apache:master Jul 5, 2019
asfgit pushed a commit that referenced this pull request Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants