-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COLLECTIONS-674] Add drain method to CollectionUtils #91
Conversation
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
You should check your tests before committing ;-) as the build fails. WRT API name, But we can do better than It feels to me like a You could reuse You should also clean up your formatting as it seems all over the place, looking at it in GitHub at least. |
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/test/java/org/apache/commons/collections4/CollectionUtilsTest.java
Outdated
Show resolved
Hide resolved
5b59b9a
to
5393c43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/commons/collections4/CollectionUtils.java
Outdated
Show resolved
Hide resolved
832e171
to
efd05c7
Compare
For COLLECTIONS-674