Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV-214: adding cache for the line ending information #20

Closed
wants to merge 1 commit into from

Conversation

nmahendru
Copy link

Description copied here from the JIRA ticket.
In my use-case , I have to read a CSV file, Mangle some columns and then write out a new csv file with those mangled columns.
I have gone through the parser code and I have found no usable way of getting the line ending information from the CSVParser object. The function readEndOfLine just consumes End of line whether it is CRLF or LF.
Now that problem is that when I am writing my file back using the CSVPrinter, I need to know what line ending my input file was. I could write an external function to do that. A better way would be to store that information in the CSVParser object and just use it.
To do that I am just saving the state in a variable and exposing that using a getter.
I have done some basic testing. and Submitting a pull request regarding that.

@coveralls
Copy link

coveralls commented Aug 10, 2017

Coverage Status

Coverage increased (+0.07%) to 94.411% when pulling ea446f0 on nmahendru:master into 4d0f226 on apache:master.

@PascalSchumacher
Copy link
Contributor

Thanks for the pull request!

Merged by @garydgregory in aae6f90

It would be nice if you could close the pull request.

Thanks!

@nmahendru
Copy link
Author

thanks for accepting it.

@nmahendru nmahendru closed this Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants