CSV-214: adding cache for the line ending information #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description copied here from the JIRA ticket.
In my use-case , I have to read a CSV file, Mangle some columns and then write out a new csv file with those mangled columns.
I have gone through the parser code and I have found no usable way of getting the line ending information from the CSVParser object. The function readEndOfLine just consumes End of line whether it is CRLF or LF.
Now that problem is that when I am writing my file back using the CSVPrinter, I need to know what line ending my input file was. I could write an external function to do that. A better way would be to store that information in the CSVParser object and just use it.
To do that I am just saving the state in a variable and exposing that using a getter.
I have done some basic testing. and Submitting a pull request regarding that.