Use final and blocks

apache · Apr 14, 2024 · c1fbb3e · c1fbb3e
1 parent 786da23
commit c1fbb3e
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java b/src/test/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriterRoundtripTest.java
@@ -90,11 +90,13 @@ private void assertTiffEquals(final TiffOutputSet sourceTiffOutputSet, final Tif
                 final List<Integer> sourceTags = new ArrayList<>();
                 final List<Integer> duplicatedTags = new ArrayList<>();
 
-                for (TiffOutputField field : sourceFields)
+                for (final TiffOutputField field : sourceFields) {
                     sourceTags.add(field.tag);
+                }
 
-                for (TiffOutputField field : duplicateFields)
+                for (final TiffOutputField field : duplicateFields) {
                     duplicatedTags.add(field.tag);
+                }
 
                 final List<Integer> missingTags = new ArrayList<>(sourceTags);
                 missingTags.removeAll(duplicatedTags);
@@ -106,7 +108,7 @@ private void assertTiffEquals(final TiffOutputSet sourceTiffOutputSet, final Tif
                 assertTrue(missingTags.isEmpty(), "Missing tags: " + missingTags);
             }
 
-            for (TiffOutputField sourceField : sourceFields) {
+            for (final TiffOutputField sourceField : sourceFields) {
                 final boolean isOffsetField =
                         sourceField.tag == ExifTagConstants.EXIF_TAG_EXIF_OFFSET.tag ||
                                 sourceField.tag == ExifTagConstants.EXIF_TAG_GPSINFO.tag ||
@@ -117,10 +119,11 @@ private void assertTiffEquals(final TiffOutputSet sourceTiffOutputSet, final Tif
                  * Ignore offset fields. They may not be needed after rewrite
                  * and their value changes anyway.
                  */
-                if (isOffsetField)
+                if (isOffsetField) {
                     continue;
+                }
 
-                TiffOutputField duplicateField = duplicateDirectory.findField(sourceField.tag);
+                final TiffOutputField duplicateField = duplicateDirectory.findField(sourceField.tag);
 
                 assertNotNull(duplicateField, "Field is missing: " + sourceField.tagInfo);