Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMAGING-230: Properly close resources with try-with-resources #48

Merged
merged 1 commit into from Jun 9, 2019
Merged

IMAGING-230: Properly close resources with try-with-resources #48

merged 1 commit into from Jun 9, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Jun 9, 2019

Just wrapped the code around a try in one method, and in the other one created two resources instead of one (properly closed) that received another (not properly closed) as constructor argument.

@kinow kinow self-assigned this Jun 9, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 74.413% when pulling df6ae68 on kinow:IMAGING-230 into 70eae6c on apache:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 74.413% when pulling df6ae68 on kinow:IMAGING-230 into 70eae6c on apache:master.

@kinow kinow merged commit 1e725b0 into apache:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kinow kinow

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@kinow @coveralls