Close OutputStream before toByteArray() on underlying ByteArrayOutputStream #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
requested changes
Sep 3, 2019
| @@ -50,6 +50,8 @@ public void write(final OutputStream os, final TiffOutputSet outputSet) | |||
| final BinaryOutputStream bos = new BinaryOutputStream(os, byteOrder); | |||
|
|
|||
| writeStep(bos, outputItems); | |||
|
|
|||
| bos.close(); | |||
There was a problem hiding this comment.
Hi @emopers
You are correct on that. The issue on this method (and I think there might be other places in Imaging with the same issue) is that this was by design.
The BinaryOutputStream created here wraps the parameter os, an OutputStream passed by the user. We shouldn't close the stream that the user passed, but calling BinaryOutputStream#close will close the underlying stream as well -
That's why some time ago, when we fixed several cases of resources left open by using the try-with-resources trick, we left this one as-is.
kinow
added a commit
that referenced
this pull request
Sep 24, 2019
|
Closing as per comment above. I've added a comment (b684eea) to let other developers know that the resource is intentionally left open. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an
OutputStreaminstance wraps an underlyingByteArrayOutputStreaminstance,it is recommended to flush or close the
OutputStreambefore invoking the underlying instances'toByteArray().This pull request adds a call to
closeat the end of thewritemethod ofTiffImageWriterLossy.