[IMAGING-163] Add XmpEmbedabble interface to parsers that support it #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't really merge it myself without another reviewer, first so that someone else helps deciding on which approach, and also because I am not really good with names. |
kinow
force-pushed
the
fix-imaging-163
branch
from
f7c8117
to
871374b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative propose to IMAGING-163. See #9 for another approach.
In this PR, a new interface
XmpEmbeddableis added. ThegetXmpXmlmethod is removed from theImageParser, and from any parser that was always returningnull.Now, instead, only the parsers that currently support XMP metadata tags implement that method. Not all parsers will implement this interface, as not all image format specifications support XMP.